Add ToSortedCollection() operator for ObservableCache and ObservableList #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
requested changes
Feb 12, 2019
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="System.Reactive" Version="4.0.0" /> | |||
| <PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-18618-05" /> | |||
There was a problem hiding this comment.
Wouldn't this be picked up due to the fact it's in the Directory.Build.Props file earlier, so this is redundant?
There was a problem hiding this comment.
The other issue is you're not doing PrivateAssets="all" so it will cause nuget users of this framework to have to inherit this nuget package.
| @@ -11,6 +11,7 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="reactiveui" Version="9.0.1" /> | |||
| <PackageReference Include="System.Reactive" Version="4.0.0" /> | |||
| <PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-18618-05" /> | |||
There was a problem hiding this comment.
Same here, this should be picked up via Directory.Build.Props
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="System.Reactive" Version="4.0.0" /> | ||
| <PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-18618-05" /> |
There was a problem hiding this comment.
In the ideal world you wouldn't have the sourcelink in the tests project anyway.
DynamicData/DynamicData.csproj
Outdated
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="System.Reactive" Version="4.0.0" /> | |||
| <PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-18618-05" /> | |||
There was a problem hiding this comment.
Same here re: directory.build.props
|
@glennawatson I reverted the SourceLink update commit |
modplug
force-pushed
the
master
branch
3 times, most recently
from
1fe9879
to
1ca74e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The good old ToCollection() does not maintain order. When ToCollection() is called it operates off the values, not the sorted values and thus I see the need for an operator that respect the sorted values