Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent ytcfilter breaks the chat in Firefox #77

Open
Nzash opened this issue Jan 30, 2021 · 1 comment
Open

Recent ytcfilter breaks the chat in Firefox #77

Nzash opened this issue Jan 30, 2021 · 1 comment

Comments

@Nzash
Copy link

Nzash commented Jan 30, 2021

I'm not sure why, but the two recent versions of ytcfilter have more or less borked the chat for me. Chat frequently freezes, then sometimes messages come in quickly, then they stop again. Superchats get "duplicated" at the top as though people send the same SCs multiple times.
The moment I turn ytcfilter off, everything works fine again. I'm unsure what change in the two recent updates caused this, but I hope it'll work right again at some point, cause I love this addon

@RomainLK
Copy link
Owner

RomainLK commented Jan 30, 2021

Do you watch Youtube on the main website or a third party one? Do you have any other extension which alter Youtube?

By chat frequently freeze, you mean Youtube's? For information, Youtube have a lot of bugs which may freeze the chat. So far, I have seen that pressing the block/report button in a VOD freeze the chat ( seems like they fixed it as I made a bug report ), and I had report that removing the pinned message also freeze it. I have also experienced freeze without the extension, so it's sadly, a really random issue.

As for message coming in quickly, do you mean in ytcFilter? In that case, that's the Fetch interceptor which no longer get messages from the livechat that you see, but straight from the data it gets from the server. If it's Youtube's chat, I'm not sure what is happening, but it can happen when you scroll up, then it tries to catch up when you get back down. Changing tab may also affect the scrolling of Youtube's chat.

Superchat getting duplicated, in ytcFilter? There is one instance I have seen of duplicate message, it's when ytcFilter switch from Mutation observer and Fetch interecptor. It will see both the message in the chat, and from server; as the switch hasn't finished, both are displayed. Normally the switch is quick so for now it's a low priority issue to me. It should happen once, but all following message shouldn't duplicate. I have normally prevented it when you seek in the video.

Could you keep an eye on "about:performance", it will give you the RAM and power usage of the extension. RAM depends of the size of your archive, but power usage is usually stays low.

For now I don't have many idea of what might be happening.

edit: I tried to see if there is any issue with SC but haven't spotted so far, on 2.1.3 ( Chrome ) and 2.1.5 (Firefox )
chrome_8rPrz2zpQb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants