Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

Added support for right-to-left shimmer #5

Closed
wants to merge 1 commit into from
Closed

Added support for right-to-left shimmer #5

wants to merge 1 commit into from

Conversation

mattlogan
Copy link

Hey there!

Nice library. I just added another styleable attribute called shimmerDirection to let the user decide the direction of the shimmer movement. It works just like LinearLayout's "layoutDirection" attribute.

@romainpiel
Copy link
Owner

Hmm interesting but I'm not sure I want to set that at the view level. It's a property related to the animation and not to the view itself. Right now the ShimmerTextView has no idea it's animating.

I was planning to convert my Shimmer.animate() to a builder and add that kind of feature.

Thanks for the PR anyway. I'll see what I can do tomorrow.

@romainpiel
Copy link
Owner

linking that to #4

@mattlogan
Copy link
Author

It makes sense that it's a property of the animation, not the view. In MainActivity you would then have something like Shimmer.animate().rightToLeft(), or Shimmer.animate().direction("rtl").

I just thought it would be easy for the user to define the shimmer direction in the same place they set the text and color (in the xml), but your explanation makes more sense from a design standpoint.

@romainpiel
Copy link
Owner

fixed in version 1.1.0

@romainpiel romainpiel closed this Mar 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants