fix(axios): handling response error on client

roman-ojha · May 29, 2022 · 6f539dd · 6f539dd · roman-ojha · May 29, 2022
1 parent b2bd77b
commit 6f539dd
Show file tree

Hide file tree

Showing 31 changed files with 233 additions and 122 deletions.
diff --git a/client/src/components/CommentBox.jsx b/client/src/components/CommentBox.jsx
@@ -91,8 +91,10 @@ const ReturnCommentContent = () => {
       }
       dispatch(stopProgressBar());
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }
@@ -128,8 +130,10 @@ const ReturnCommentContent = () => {
         }
         dispatch(stopProgressBar());
       } catch (err) {
-        if (err.response.data.success === false) {
-          toastError(err.response.data.msg);
+        if (err.response) {
+          if (err.response.data.success === false) {
+            toastError(err.response.data.msg);
+          }
         } else {
           toastError("Some Problem Occur, Please Try again later!!!");
         }

diff --git a/client/src/components/FollowedBy.jsx b/client/src/components/FollowedBy.jsx
@@ -61,8 +61,10 @@ const FollowedBy = () => {
             dispatch(stopProgressBar());
           }
         } catch (err) {
-          if (err.response.data.success === false) {
-            toastError(err.response.data.msg);
+          if (err.response) {
+            if (err.response.data.success === false) {
+              toastError(err.response.data.msg);
+            }
           } else {
             toastError("Some Problem Occur, Please Try again later!!!");
           }
@@ -103,8 +105,10 @@ const FollowedBy = () => {
             dispatch(stopProgressBar());
           }
         } catch (err) {
-          if (err.response.data.success === false) {
-            toastError(err.response.data.msg);
+          if (err.response) {
+            if (err.response.data.success === false) {
+              toastError(err.response.data.msg);
+            }
           } else {
             toastError("Some Problem Occur, Please Try again later!!!");
           }
@@ -135,8 +139,10 @@ const FollowedBy = () => {
         }
         dispatch(stopProgressBar());
       } catch (err) {
-        if (err.response.data.success === false) {
-          toastError(err.response.data.msg);
+        if (err.response) {
+          if (err.response.data.success === false) {
+            toastError(err.response.data.msg);
+          }
         } else {
           toastError("Some Problem Occur, Please Try again later!!!");
         }

diff --git a/client/src/components/HomePage/DisplayFollowedUserPost.jsx b/client/src/components/HomePage/DisplayFollowedUserPost.jsx
@@ -27,12 +27,13 @@ const DisplayFollowedUserPost = () => {
               />
             );
           });
-          if (
-            followedUserPostDataStore.length === 1 &&
-            postElement[0].props.userMainInformation.userID ===
+          if (followedUserPostDataStore.length === 1 && postElement[0]) {
+            if (
+              postElement[0].props.userMainInformation.userID ===
               admin.adminUserID
-          ) {
-            return [<DefaultSocialPost key={key} />, ...postElement];
+            ) {
+              return [<DefaultSocialPost key={key} />, ...postElement];
+            }
           } else if (postElement.length > 0) {
             return postElement;
           } else {

diff --git a/client/src/components/HomePage/MaxViewPostField/PostButton.jsx b/client/src/components/HomePage/MaxViewPostField/PostButton.jsx
@@ -46,8 +46,10 @@ const PostButton = () => {
       dispatch(showLoadingSpinner(false));
       dispatch(setHomePagePostFieldViewValue("min"));
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }

diff --git a/client/src/components/MainPageMsgAndNtfBar.jsx b/client/src/components/MainPageMsgAndNtfBar.jsx
@@ -57,8 +57,10 @@ const MainPageMsgAndNtfBar = () => {
         toastError(data.msg);
       }
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }
@@ -82,8 +84,10 @@ const MainPageMsgAndNtfBar = () => {
       }
       dispatch(stopProgressBar());
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }

diff --git a/client/src/components/MainPageStoryComp/MainPageStory.jsx b/client/src/components/MainPageStoryComp/MainPageStory.jsx
@@ -8,7 +8,6 @@ import FriendStory from "./FriendStory";
 const MainPageStory = () => {
   const userStoriesStore = useSelector((state) => state.userStoriesReducer);
   // console.log(userStoriesStore);
-  const storiesData = userStoriesStore.data;
   const isMobile = useMediaQuery({
     query: "(max-width: 480px)",
   });

diff --git a/client/src/components/MessageBox/MessagesListSingleMessage.jsx b/client/src/components/MessageBox/MessagesListSingleMessage.jsx
@@ -1,54 +1,58 @@
 import React from "react";
 import User_Profile_Icon from "../../assets/svg/User_profile_Icon.svg";
-import socket from "../../services/socket";
 import {
   currentUserMessageAction,
   mainPageMessageInnerViewOnOff,
 } from "../../services/redux-actions/index";
 import { useDispatch } from "react-redux";
 import { instance as axios } from "../../services/axios";
+import { toastError } from "../../services/toast";
 
 const MessagesListSingleMessage = (props) => {
   const dispatch = useDispatch();
   const showInnerMessage = async () => {
-    // before getting new message we will reset the previous message stored into redux
-    dispatch(
-      currentUserMessageAction({
-        messageToId: props.messageInfo.messageToId,
-        messageToUserId: props.messageInfo.messageToUserId,
-        receiverPicture: props.messageInfo.receiverPicture,
-        message: [],
-        fetchedInnerMessage: false,
-      })
-    );
-    dispatch(mainPageMessageInnerViewOnOff(true));
-    const resMessage = await axios({
-      // sending receiver userID to get message data of that user
-      method: "POST",
-      url: "/u/getMessage",
-      headers: {
-        "Content-Type": "application/json",
-      },
-      data: JSON.stringify({
-        userID: props.messageInfo.messageToUserId,
-        id: props.messageInfo.messageToId,
-      }),
-      withCredentials: true,
-    });
-    if (resMessage.status !== 200) {
-      const error = await resMessage.data;
-    } else {
-      const resData = await resMessage.data;
-      // after getting message we will store that message into redux
+    try {
+      // before getting new message we will reset the previous message stored into redux
       dispatch(
         currentUserMessageAction({
           messageToId: props.messageInfo.messageToId,
           messageToUserId: props.messageInfo.messageToUserId,
           receiverPicture: props.messageInfo.receiverPicture,
-          message: resData.message,
-          fetchedInnerMessage: true,
+          message: [],
+          fetchedInnerMessage: false,
         })
       );
+      dispatch(mainPageMessageInnerViewOnOff(true));
+      const resMessage = await axios({
+        // sending receiver userID to get message data of that user
+        method: "POST",
+        url: "/u/getMessage",
+        headers: {
+          "Content-Type": "application/json",
+        },
+        data: JSON.stringify({
+          userID: props.messageInfo.messageToUserId,
+          id: props.messageInfo.messageToId,
+        }),
+        withCredentials: true,
+      });
+      if (resMessage.status !== 200) {
+        const error = await resMessage.data;
+      } else {
+        const resData = await resMessage.data;
+        // after getting message we will store that message into redux
+        dispatch(
+          currentUserMessageAction({
+            messageToId: props.messageInfo.messageToId,
+            messageToUserId: props.messageInfo.messageToUserId,
+            receiverPicture: props.messageInfo.receiverPicture,
+            message: resData.message,
+            fetchedInnerMessage: true,
+          })
+        );
+      }
+    } catch (err) {
+      toastError("Some Problem Occur, Please Try again later!!!");
     }
   };
 

diff --git a/client/src/components/MessagePage/MessagesList.jsx b/client/src/components/MessagePage/MessagesList.jsx
@@ -24,8 +24,10 @@ const MessagesList = () => {
       }
       setShowLoadingSpinner(false);
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }

diff --git a/client/src/components/MessagePage/MessagesListSingleMessage.jsx b/client/src/components/MessagePage/MessagesListSingleMessage.jsx
@@ -53,8 +53,10 @@ const MessageListSingleMessage = (props) => {
         );
       }
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }

diff --git a/client/src/components/MessagePage/SendMessageInputField.jsx b/client/src/components/MessagePage/SendMessageInputField.jsx
@@ -7,6 +7,7 @@ import {
 } from "../../services/redux-actions/index";
 import { Icon } from "@iconify/react";
 import { isEmptyString } from "../../funcs/isEmptyString";
+import { toastError } from "../../services/toast";
 
 const SendMessageInputField = (props) => {
   const dispatch = useDispatch();
@@ -57,7 +58,7 @@ const SendMessageInputField = (props) => {
         }
       });
     } catch (err) {
-      // console.log(err);
+      toastError("Some Problem Occur, Please Try again later!!!");
     }
   };
 

diff --git a/client/src/components/PostBox/CommentField.jsx b/client/src/components/PostBox/CommentField.jsx
@@ -55,8 +55,10 @@ const CommentField = (props) => {
       }
       dispatch(stopProgressBar());
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }

diff --git a/client/src/components/PostBox/CommentedUser.jsx b/client/src/components/PostBox/CommentedUser.jsx
@@ -47,8 +47,10 @@ const CommentedUser = (props) => {
       }
       dispatch(stopProgressBar());
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }

diff --git a/client/src/components/PostBox/LikeCommentShare.jsx b/client/src/components/PostBox/LikeCommentShare.jsx
@@ -46,8 +46,10 @@ const LikeCommentShare = (props) => {
         });
       }
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }
@@ -80,8 +82,10 @@ const LikeCommentShare = (props) => {
       }
       dispatch(stopProgressBar());
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }

diff --git a/client/src/components/PostBox/PostInfo.jsx b/client/src/components/PostBox/PostInfo.jsx
@@ -85,8 +85,10 @@ const PostInfo = (props) => {
       }
       dispatch(stopProgressBar());
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
         toastError("Some Problem Occur, Please Try again later!!!");
       }

diff --git a/client/src/components/ProfileFriends.jsx b/client/src/components/ProfileFriends.jsx
@@ -60,10 +60,12 @@ const ProfileFriends = () => {
         toastError("Some Error Occur While Fetching Friends Data");
       }
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
-        toastError("Some Problem Occur while fetching friends data");
+        toastError("Some Problem Occur, Please Try again later!!!");
       }
     }
   };
@@ -82,10 +84,12 @@ const ProfileFriends = () => {
         toastError("Some Error Occur While Fetching Friends Data");
       }
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
-        toastError("Some Problem Occur while fetching friends data");
+        toastError("Some Problem Occur, Please Try again later!!!");
       }
     }
   };
@@ -104,10 +108,12 @@ const ProfileFriends = () => {
         toastError("Some Error Occur While Fetching Friends Data");
       }
     } catch (err) {
-      if (err.response.data.success === false) {
-        toastError(err.response.data.msg);
+      if (err.response) {
+        if (err.response.data.success === false) {
+          toastError(err.response.data.msg);
+        }
       } else {
-        toastError("Some Problem Occur while fetching friends data");
+        toastError("Some Problem Occur, Please Try again later!!!");
       }
     }
   };