Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vietnamese version for this guide #45

Closed
lploc94 opened this issue May 20, 2019 · 3 comments · Fixed by #46
Closed

Add vietnamese version for this guide #45

lploc94 opened this issue May 20, 2019 · 3 comments · Fixed by #46

Comments

@lploc94
Copy link
Contributor

lploc94 commented May 20, 2019

Hi, I see this guide is very helpful, but the truth that there are a few Vietnamese peoples know this guide. I want to translate this guide to Vietnamese so that it can be popular in Vietnamese developer community. I have read CONTRIBUTING.md carefuly. I hope I can help by adding a README_vi-VI.md file for Vietnamese version.
@RomuloOliveira
Copy link
Owner

Hi, @lploc94, a translation was made at #37 but unfortunately the author has closed the PR and deleted the repository. I have a backup of the Vietnamese translation, though.

Would this help you? I can open a new pull request with his translation and you could help with review and making changes.

@RomuloOliveira RomuloOliveira mentioned this issue May 23, 2019
Merged
@RomuloOliveira
Copy link
Owner

Just did that #46

@lploc94
Copy link
Contributor Author

lploc94 commented Jun 22, 2019

Hi, I have some change at my company then I forgot to check my Github. I have added a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Vietnamese version RomuloOliveira/commit-messages-guide
2 participants
@RomuloOliveira @lploc94