Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Auto-Heal Socket Close #9

Closed
wants to merge 1 commit into from
Closed

✨ Auto-Heal Socket Close #9

wants to merge 1 commit into from

Conversation

ghunkins
Copy link

@ghunkins ghunkins commented Dec 6, 2021

Problem Statement

Socket gets closed silently by normal events (i.e. app to background). See #8 for more description.

Fix

Listen to onError and onDone events and re-open the connection when those events are fired.

@ghunkins
Copy link
Author

ghunkins commented Dec 9, 2021

@RootSoft Please let me know if there's any other information you need, or if there's anything I can do to help expedite this. Thanks!

@RootSoft
Copy link
Owner

@ghunkins Thanks for the PR and sorry for the late response.
I've checked the PR, however the wallet can send a killSession and your PR might get stuck in a loop.
I think some extra checks needs to be in place with some additional testing

@josh-burton
Copy link
Contributor

@RootSoft Please let me know if there's any other information you need, or if there's anything I can do to help expedite this. Thanks!

Are you still keen on updating this PR?

@RootSoft
Copy link
Owner

@josh-burton I've been working on an implementation yesterday and having some good results to keep the connection alive when navigating from background and reconnecting:

Feel free to try out:
https://github.com/RootSoft/walletconnect-dart-sdk/tree/feat/reconnecting-we-socket

I'll be merging it soon

@ghunkins
Copy link
Author

ghunkins commented Mar 7, 2022

@RootSoft thanks for running with this. Been caught up with other things, and my patch fix is definitely ugly but works for my purposes for now.

Happy to review / test if you put out a PR!

@RootSoft
Copy link
Owner

RootSoft commented Mar 8, 2022

@ghunkins Thanks, the changes are now available on master & v0.0.8.
See #8 (comment)

I will close this PR.

@RootSoft RootSoft closed this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants