Fixes.cpp

#include "Global.hpp"
#include "sodsp/Log.hpp"
#include "Fixes.hpp"
#include "AnchorBug.hpp"
#include "HorizontalScrollbar.hpp"

using namespace h3;
using ftr::FOptions;

//////////////////////////////////////////////////////////////////////////
// AI bugs
//////////////////////////////////////////////////////////////////////////

/*
 *
 * This hook prevents AI from casting Town Portal on Cursed Ground
 *
 */
_LHF_(AiTpCursedCheck)
{
	LOG_LOHOOK;
	if (!F_Multiplayer() && FOptions.ai_cheats)
	{
		H3Hero *hero = (H3Hero*)c->esi;
		if (hero->GetSpecialTerrain() == NH3Objects::CURSED_GROUND)
		{
			c->return_address = 0x56B6F4;
			return NO_EXEC_DEFAULT;
		}
	}
	return EXEC_DEFAULT;
}

/*
 *
 * This hook prevents division by 0 during tactics phase when you have no army.
 * When AI has tactics or attacks you, they split their shooters...
 *
 */
_LHF_(AiSplitDiv0)
{
	LOG_LOHOOK;
	if (c->ebx == 0) // ... if the other hero has no army, it will divide by 0
		c->ebx = 1; // make it 1 to avoid changing much and prevent crash

	return EXEC_DEFAULT;
}

/*
 *
 * This hook prevents AI from casting Fly if they don't have it.
 *
 */
_LHF_(AiWaterwalkFly)
{
	LOG_LOHOOK;
	if (!F_Multiplayer() && c->eax == 0 && FOptions.ai_cheats)
	{
		H3Hero *hero = (H3Hero *)(c->esi);
		if (!hero->HasSpell(int(H3Spell::eSpells::FLY))) // this AI hero does not have the means to cast fly
		{
			if (hero->HasSpell(int(H3Spell::eSpells::WATER_WALK))) // this AI hero has access to waterwalk
			{
				if (hero->waterwalkPower == -1) // waterwalk is not cast
					c->return_address = 0x430231;
				else
					c->return_address = 0x430540;

				return NO_EXEC_DEFAULT;
			} // waterwalk available
		} // fly available
	} // mp game && no angel wings
	return EXEC_DEFAULT;
}

/*
 *
 * The AI was observed to divide by speed = 0 in "Rise of The Sun King"
 *
 */
_LHF_(AI_combat_div0)
{
	LOG_LOHOOK;
	if (c->edi == 0)
		c->edi = 1;

	return EXEC_DEFAULT;
}

/*
 *
 * This hook [1] allows AI to raise more than one necromancy creature.
 * It skips deletion of loser's army which will be done later.
 *
 */
_LHF_(AI_NecromancyFix)
{
	LOG_LOHOOK;
	if (!F_Multiplayer() && FOptions.AI_necromancy)
	{
		c->return_address = 0x426FED;
		return NO_EXEC_DEFAULT;
	}

	return EXEC_DEFAULT;
}

/*
 *
 * This hook [2] allows AI to raise more than one necromancy creature.
 * It restores deletion of loser's army which was skipped by @AI_NecromancyFix
 *
 */
void __stdcall _HH_AI_NecromancyFix(HiHook *h, H3AiFastBattle *winner, H3AiFastBattle *loser, int town)
{
	LOG_HIHOOK;
	THISCALL_3(void, h->GetDefaultFunc(), winner, loser, town);
	if (!F_Multiplayer() && FOptions.AI_necromancy)
		loser->DeleteCreatures();
}

/*
 *
 * The AI was observed to deal negative damage in quick battle in "+ The Last Crusade +"
 * when having a large army. This caps damage to 2^31 - 1.
 *
 */
int __stdcall _HH_AI_QB_GetDamage(HiHook *h, H3AiFastBattle *This, int a1, int a2)
{
	LOG_HIHOOK;
	int r = THISCALL_3(int, h->GetDefaultFunc(), This, a1, a2);

	if (FOptions.quickbattle_overflow && This->armyStrength > 0 && r < 0)
		r = INT_MAX;
	return r;
}

/*
 *
 * The AI with very large army may calculate its army strength as negative and lose easy battles.
 * This caps power to 2^31 - 1.
 *
 */
void __stdcall _HH_AI_QB_hugeArmy(HiHook *h, H3AiFastBattle *This, int a1, int a2, int a3)
{
	LOG_HIHOOK;
	if (FOptions.quickbattle_overflow && This->armyStrength < 0)
		This->armyStrength = INT_MAX;
	THISCALL_4(void, h->GetDefaultFunc(), This, a1, a2, a3);
}

/*
 *
 * The AI was observed to spawn creatures during Quick Combat, finishing with more
 * creatures than it started the combat with.
 * This hook is applied before @AI_NecromancyFix.
 *
 */
void __stdcall _HH_AI_PreventCreatureSpawning(HiHook *h, H3AiFastBattle *This, int a2)
{
	LOG_HIHOOK;
	const BOOL valid = (!F_Multiplayer() && FOptions.quickbattle_overflow);
	H3Army backup;
	if (valid)
		backup = *This->army;
	THISCALL_2(void, h->GetDefaultFunc(), This, a2);
	if (valid)
	{
		H3Army *army = This->army;
		for (int i = 0; i < 7; i++)
		{
			if (army->type[i] != -1 && army->count[i] > backup.count[i])
				army->count[i] = backup.count[i];
		}
	}
}

/*
 *
 * The AI with very large army may calculate army strength as negative and enter infinite loops.
 * This caps power to 2^31 - 1.
 *
 */
int __stdcall _HH_AI_GetArmyValue(HiHook *h, H3Army *This)
{
	LOG_HIHOOK;
	int r = THISCALL_1(int, h->GetDefaultFunc(), This);
	if (FOptions.quickbattle_overflow && r < 0)
		r = INT_MAX - 500; // - 500 is needed as sometimes this is used to calculate experience and if a town/hero is present it will overflow.
	return r;
}

/*
 *
 * The AI does not consider its own Death Knights when trying to build
 * Necromancy Amplifier, only its Necromancers.
 *
 */
_LHF_(AI_DeathKnightsAmplifier)
{
	LOG_LOHOOK;
	if (!FOptions.ai_cheats) // not really a cheat but affects normal game behaviour
		return EXEC_DEFAULT;
	if (PH3Hero(c->eax)->hero_class == NH3Heroes::eHeroClasses::DEATH_KNIGHT)
		return NO_EXEC_DEFAULT;
	return EXEC_DEFAULT;
}

//////////////////////////////////////////////////////////////////////////
// Turret towers bugs
//////////////////////////////////////////////////////////////////////////

/*
 *
 * These hooks correct the Armorer / Air Shield vs. Arrow Turret bug.
 * A much simpler fix exists but this was simplest for SoD_SP's scope.
 *
 */
_H3API_NAKED_FUNCTION_ TurretBug1(void)
{
	static naked_t return_turret1 = (naked_t)0x41E3A6;

	__asm PUSHFD
	__asm PUSHAD
	if (!F_Multiplayer() && FOptions.turrets)
	{
		__asm POPAD
		__asm POPFD
		__asm MOV EAX, 0x443AB0
		__asm CALL EAX
		__asm FMUL QWORD PTR SS : [EBP - 8]
	}
	else
	{
		__asm POPAD
		__asm POPFD
		__asm MOV EAX, 0x443AB0
		__asm CALL EAX
		__asm FDIVR QWORD PTR SS : [EBP - 8]
	}

	__asm JMP return_turret1
}

_H3API_NAKED_FUNCTION_ TurretBug2(void)
{
	static naked_t return_turret2 = (naked_t)0x41E4E2;
	__asm PUSHFD
	__asm PUSHAD
	if (!F_Multiplayer() && FOptions.turrets)
	{
		__asm POPAD
		__asm POPFD
		__asm MOV EAX, 0x443AB0
		__asm CALL EAX
		__asm FMUL QWORD PTR SS : [EBP - 8]
	}
	else
	{
		__asm POPAD
		__asm POPFD
		__asm MOV EAX, 0x443AB0
		__asm CALL EAX
		__asm FDIVR QWORD PTR SS : [EBP - 8]
	}
	__asm JMP return_turret2
}

_H3API_NAKED_FUNCTION_ turret_bug3(void)
{
	static naked_t return_turret3 = (naked_t)0x465946;

	__asm PUSHFD
	__asm PUSHAD
	if (!F_Multiplayer() && FOptions.turrets)
	{
		__asm POPAD
		__asm POPFD
		__asm MOV EAX, 0x443AB0
		__asm CALL EAX
		__asm FMUL QWORD PTR SS : [EBP - 0x2C]
	}
	else
	{
		__asm POPAD
		__asm POPFD
		__asm MOV EAX, 0x443AB0
		__asm CALL EAX
		__asm FDIVR QWORD PTR SS : [EBP - 0x2C]
	}
	__asm JMP return_turret3
}

//////////////////////////////////////////////////////////////////////////
// GUI errors
//////////////////////////////////////////////////////////////////////////

/*
 *
 * The creature dialog of Faerie Dragon's would show 'Sawmill' for their
 * spell icon hint.
 *
 */
_LHF_(FaerieDialogHover)
{
	LOG_LOHOOK;
	if (c->eax == 0x0F)
	{
		c->edi = IntAt(0x6A6A00); // "Cast Spell" text ~ taken from 0x46B4FE
		return NO_EXEC_DEFAULT;
	}
	return EXEC_DEFAULT;
}

/*
 *
 * The creature dialog of Faerie Dragon's would show 'Sawmill' for their
 * spell icon right-click message.
 *
 */
_LHF_(FaerieDialogRmb)
{
	LOG_LOHOOK;
	if (c->esi == 0x0F)
	{
		c->esi = IntAt(0x6A6A00); // "Cast Spell" text ~ taken from 0x46B4FE
		return NO_EXEC_DEFAULT;
	}
	return EXEC_DEFAULT;
}

/*
 *
 * Alignment of some icons and use of correct icons.
 * Patch by igrik.
 *
 */
void GuiFixesByIgrik()
{
	// cancel button in tavern
	// iCancel.def to iCN6432.def
	H3Patcher::DwordPatch(0x5D7AC9 + 1, 0x682A24);

	// cancel button in creature swapmanager window
	// iCancel.def to iCN6432.def
	H3Patcher::DwordPatch(0x449A40 + 1, 0x682A24);

	/////////////////////////////////////////////
	// fix Faerie Dragon button coordinates
	/////////////////////////////////////////////
	// Y position
	// 0xEC to 0xEB
	H3Patcher::BytePatch(0x5F3D9E + 1, 0xEB);

	// X position
	// 0x4A to 0x15
	H3Patcher::BytePatch(0x5F3DA3 + 1, 0x15);

	// Y position
	// 0xEC to 0xEB
	H3Patcher::BytePatch(0x5F3DF4 + 1, 0xEB);

	// X position
	// 0x4A	to 0x15
	H3Patcher::BytePatch(0x5F3DF9 + 1, 0x15);
}

//////////////////////////////////////////////////////////////////////////
// Misc. errors
//////////////////////////////////////////////////////////////////////////

/*
 *
 * Wait Phase Bug [2].
 * Because Wait Phase Bug [1] restores access to a function at all times,
 * portion of its code must be skipped during Wait Phase.
 *
 */
_LHF_(WaitPhaseBug)
{
	LOG_LOHOOK;
	if (P_CombatMgr()->waitPhase) // we need to prevent regen abilities or elixir of life to trigger
		c->flags.ZF = TRUE;     // because it was not supposed to act in this phase
	return EXEC_DEFAULT;
}

/*
 *
 * The nwczion cheat flag is not always reset.
 *
 */
void NwcZionBug()
{
	ByteAt(0x6AAAC4) = 0;
}

/*
 *
 * Called by FindMe at the same time disabled events get hidden.
 *
 * If the dialog to select which creatures to keep is created, the ShowHero() function is called.
 * This function places the hero's data over H3MapItem which normally stores the data for the event.
 * The event's data in turn is stored in H3Hero->objectBelow entries.
 * Normally after visiting the event is complete, there is a check whether the event is a one-time only thing,
 * however if ShowHero() was called then the H3MapItem->setup field only contains the hero ID (0~156) and
 * never the trigger for the single visit of and event.. thus not disabling it.
 * With this fix, we simply emulate the code at 0x4A0C30 to remove the reference to the event.
 * The next time HideHero() is called, it will replace the data of H3MapItem with the now blank hero->objectBelow entries
 *
 */
BOOL RevisitEventBug(H3Hero *hero)
{
	if (FOptions.event_repeat_bug && (hero->isVisible) && (hero->objectTypeUnder == NH3Objects::EVENT)
		&& ((MapEvent*)& hero->objectBelowSetup)->oneVisit)
	{
		hero->objectTypeUnder = 0; // equivalent to line 0x4A0C30
		hero->objectBelowSetup = 0; // equivalent to line 0x4A0C36
		// line 0x4A0C2A will be handled later by HideHero() when he moves away, focus is changed, hero is dismissed, or killed
		return TRUE;
	}
	return FALSE;
}

/*
 *
 * When opening the creature trade window rapidly, a structure is written upon hover.
 * If you click rapidly in repetition (e.g. revisiting event to spawn creatures),
 * this piece of code may be executed before being populated - resulting in crash to desktop.
 * Observed in "Bug Race".
 *
 */
_LHF_(ViewHeroScreenRapidly)
{
	LOG_LOHOOK;
	if (!c->eax)
		c->eax = reinterpret_cast<int>(reinterpret_cast<H3TownManager*>(c->esi)->bottom);
	return EXEC_DEFAULT;
}

/*
 *
 * Similar to @RevisitEventBug except for Creature Banks.
 * Instead of being able to spawn creatures, here it results in crash to desktop.
 *
 */
_LHF_(VisitBankBug)
{
	LOG_LOHOOK;
	const auto mip = reinterpret_cast<H3MapItem*>(c->eax);
	if (mip->objectType == NH3Objects::HERO)
		P_AdventureMgr()->MobilizeHero();
	return EXEC_DEFAULT;
}

/*
 *
 * Earthquake can incorrectly target creature in position 0 and set its flag
 * to CANNOT_MOVE, a.k.a. War Machine. Since a Hero cannot survive with only War Machines,
 * he would be defeated.
 *
 */
_LHF_(EarthquakeBug)
{
	LOG_LOHOOK;
	if (!F_Multiplayer() && FOptions.earthquake_bug)
	{
		const auto mon = reinterpret_cast<H3CombatMonster *>(c->eax - offsetof(H3CombatMonster, info.flags));
		if (mon->sideIndex == 0)
			return NO_EXEC_DEFAULT;
	}
	return EXEC_DEFAULT;
}

/*
 *
 * Proposed by Ben80
 * If wandering monster had upgraded stack, it would only restore creatures of the base type.
 * This apparent bug in the code stems from the fact that the parent function could be used
 * to add extra creatures (see arguments 6, 9, ...) but was only ever used for Pyramid...
 * Pyramid creatures always reset so essentially it's an abandonned feature that was
 * not properly tested.
 *
 */
_LHF_(PreserveMonsterNumber)
{
	LOG_LOHOOK;
	if (!F_Multiplayer() && c->Arg(6) == -1 && c->Arg(9) == -1 && FOptions.vanish)
	{
		c->esp += 4; // pop edi
		auto monsters = reinterpret_cast<H3Army*>(c->ecx);
		int mon_number = 0;

		for (int i = 0; i < 7; i++)
			mon_number += monsters->count[i]; // restore count no matter if it is an upgraded creature or not
		c->eax = mon_number;
		return NO_EXEC_DEFAULT;
	}
	return EXEC_DEFAULT;
}

/*
 *
 * Heroes set as 'Can be Hired by' players X in the mapeditor are not preserved
 * in certain occasions. This hook maintains the hero's hireability as set in h3m.
 * Observed in "Metataxer's Revenge".
 *
 */
_LHF_(FixHireables)
{
	LOG_LOHOOK;
	if (!F_Multiplayer() || FOptions.tavern_heroes)
		return NO_EXEC_DEFAULT;
	return EXEC_DEFAULT;
}

/*
 *
 * This hook fixes def-type1 drawing parameters which are incorrect (width instead of x).
 * The same error exists in the mapeditor...
 *
 */
_LHF_(DefType1)
{
	LOG_LOHOOK;
	c->Push(c->eax);
	c->Push(c->ecx);
	c->Push(c->Arg(1));
	c->ecx = c->edx;
	return NO_EXEC_DEFAULT;
}

/*
 *
 * When casting Dimension Door or Town Portal on the adventure map,
 * the game computes and subtracts spell cost *after* the hero has moved.
 * This can therefore increase or decrease the actual spell cost you
 * were supposed to pay depending on what type of terrain was under the hero
 * at cast time compared to what type pf terrain is under the hero at destination.
 * e.g. No Air magic -> DD costs 25 SP
 *      Standing on Magic Plains [cost reduction to 20 SP]
 *      Cast DD -> land on regular terrain
 *      DD now costs 25 SP on regular terrain...
 *      hero gets 25 SP deducted instead of the advertized 20
 * This hook calculates and deducts the spell cost
 * before the hero has moved to his new destination.
 *
 */
_LHF_(FixDimensionDoorSpellCost)
{
	LOG_LOHOOK;
	c->eax = P_Spell()(H3Spell::eSpells::DIMENSION_DOOR)->mana_cost[c->Arg(1)];
	c->return_address = 0x41D444;
	return NO_EXEC_DEFAULT;
}

// * see extended description of @FixDimensionDoorSpellCost
// * Subtracts the correct amount of spell points from hero when casting Town Portal
_LHF_(FixTownPortalSpellCost)
{
	LOG_LOHOOK;
	PH3Hero hero = PH3Hero(c->esi);
	hero->RemoveSpellPointsAndRefresh(hero->CalculateAdventureMapSpellCost(H3Spell::eSpells::TOWN_PORTAL));
	return EXEC_DEFAULT;
}

// * see extended description of @FixDimensionDoorSpellCost
// * skips over original code for subtracting spell points when casting Town Portal
_LHF_(SkipOldTownPortalSpellCost)
{
	LOG_LOHOOK;
	c->return_address = 0x41DA2B;
	return NO_EXEC_DEFAULT;
}

/*
 *
 * When preparing the text string to calculate damage done by shooters
 * no check was done on the creature being affected by Forgetfulness
 *
 */
_LHF_(DamageOutputForgetfulness)
{
	LOG_LOHOOK;
	if (PH3CombatMonster(c->esi)->activeSpellsDuration[H3Spell::eSpells::FORGETFULNESS] > 0 && c->eax > 1)
		c->eax >>= 1; // reduce count by half
	return EXEC_DEFAULT;
}

//////////////////////////////////////////////////////////////////////////
// Movement
//////////////////////////////////////////////////////////////////////////

/*
 *
 * A simple update of the hero's max land movement after landing.
 *
 */
_LHF_(UpdateMaxLandMovement)
{
	LOG_LOHOOK;
	H3Hero* hero = reinterpret_cast<H3Hero*>(c->esi);
	hero->maxMovement = hero->MaxLandMovement();
	return EXEC_DEFAULT;
}

/*
 *
 * After visiting movement boosting objects, the hero's max movement field
 * is boosted but then reset if you view the Hero dialog.
 *
 */
_LHF_(RecalculateMovementAfterVisitObject)
{
	LOG_LOHOOK;
	H3Hero* hero = reinterpret_cast<H3Hero*>(c->edi);
	hero->maxMovement = hero->CalcMaxMovement();
	return EXEC_DEFAULT;
}

/*
 *
 * After visiting a town, a hero may have gained access to Stables (Castle)
 * or gained a level (Dungeon) and their maximum movement may have changed.
 *
 */
_LHF_(RecaculateMovementAfterExitingTown)
{
	LOG_LOHOOK;
	H3Hero* hero = (H3Hero*)c->eax;
	hero->maxMovement = hero->CalcMaxMovement();
	return EXEC_DEFAULT;
}

/*
 *
 * When trading artifacts and exiting the trade dialog with the second hero,
 * the maximum movement would not be updated.
 *
 */
void __stdcall _HH_HeroesMeeting(HiHook *h, H3AdventureManager *This, H3Hero *hero, H3MapItem *dest, H3Position position, BOOL8 human)
{
	LOG_HIHOOK;
	auto second_hero = P_Main()->GetHero(dest->setup);
	BOOL same_owner = FALSE;
	if (second_hero)
		same_owner = hero->owner == second_hero->owner;

	THISCALL_5(void, h->GetDefaultFunc(), This, hero, dest, position.Mixed(), human);

	if (human && same_owner)
		second_hero->maxMovement = second_hero->CalcMaxMovement();
}

/*
 *
 * Cycles through a player's heroes currently on the map and updates their
 * maximum water movement.
 *
 */
void UpdateHeroesMaxMvmtInWater()
{
	H3Hero *hero;
	H3Player *me = P_ActivePlayer();
	H3Main *main = P_Main();
	for (auto hero_id : me->heroIDs)
	{
		if (((hero = main->GetHero(hero_id))) && hero->flags.inBoat)
			hero->maxMovement = hero->MaxWaterMovement();
	}
}

/*
 *
 * After visiting a Lighthouse, all heroes currently in water
 * need their maximum movement to be updated.
 *
 */
_LHF_(UpdateSeaMvmtLighthouse)
{
	LOG_LOHOOK;
	if (c->Arg<BYTE>(4)) // only if human
		UpdateHeroesMaxMvmtInWater();
	return EXEC_DEFAULT;
}

/*
 *
 * Similar to @UpdateSeaMvmtLighthouse but in the case of building a Castle's Lighthouse.
 *
 */
int __stdcall _HH_AfterBuildingLighthouse(HiHook *h, const H3Town *This, const int building_id)
{
	LOG_HIHOOK;
	int r = THISCALL_2(int, h->GetDefaultFunc(), This, building_id);

	if (h->GetReturnAddress() == 0x5BF262) // only care about when I build it
	{
		if (This->type == int(H3Town::eTown::CASTLE) && building_id == int(H3Town::eBuildings::B_LIGHTHOUSE)) // if castle and building a lighthouse
		{
			if (This->owner == P_CurrentPlayerID()) // only care about human
				UpdateHeroesMaxMvmtInWater();
		}
	}
	return r;
}

/*
 *
 * Built Lighthouses in Castle towns would apply movement bonus to every hero on the map.
 * A check is made on the castle's owner and the procedure is skipped when necessary.
 *
 */
_LHF_(CastleLighthouseOwnerCheck)
{
	LOG_LOHOOK;
	if (FOptions.movement_bugs)
	{
		const auto town = reinterpret_cast<H3Town*>(c->ecx);
		const auto hero = c->Local<PH3Hero>(1); // H3Hero is stored in temp variable [LOCAL.1]

		if (hero->owner == town->owner) // normal
			return EXEC_DEFAULT;

		c->return_address = 0x4E4D6C; // skip procedure
		return NO_EXEC_DEFAULT;
	}
	return EXEC_DEFAULT;
}

/*
 *
 * This hook modifies the cursor type when targetting an enemy with the First Aid Tent.
 * In this subroutine, the code checks if the First Aid Tent can target an enemy (which it can't)
 *
 */
BOOL8 __stdcall _HH_FirstAidTentTargetEnemy(HiHook* h, H3CombatMonster* This, int a2, int a3)
{
	LOG_HIHOOK;
	if (This->type == NH3Creatures::FIRST_AID_TENT)
		return false;
	return THISCALL_3(BOOL8, h->GetDefaultFunc(), This, a2, a3);
}

/*
 *
 * This hook properly updates the enchanters' targeting loop to a new creature.
 * Otherwise, only the first stack is considered, possibly resulting in lack of casts
 * even though valid spell targets are still available.
 *
 */
_LHF_(EnchantersTargetting)
{
	LOG_LOHOOK;
	if (FOptions.Enchanters_cast_fix)
		c->Local(3) += sizeof(H3CombatMonster);
	return EXEC_DEFAULT;
}

/*
 *
 * If you edit an object that should have entrance to not get any
 * the text buffer is not reset and you get can get random text.
 *
 */
_LHF_(ResetTextBufferForAdventureHint)
{
	h3_TextBuffer[0] = 0;
	return EXEC_DEFAULT;
}

/*
 *
 * When creating RMG map description, player's town selection
 * uses player's id instead of selected town to get its name.
 *
 */
_LHF_(RMGPlayerTownSelection)
{
	c->eax = (*c->Local<INT8*>(4)) * 4;
	return EXEC_DEFAULT;
}

/**
 * @brief follows the logic from 0x479A5B that prevents summoning a clone
 * if too many creatures are present
 */
BOOL MaximumCreaturesReached(H3CombatManager* cmb, INT side)
{
	INT i = 0;
	H3CombatMonster* mon = cmb->stacks[side];
	while (mon->type != NH3Creatures::eH3Creatures::UNDEFINED)
	{
		if (!mon->numberAlive && mon->info.flags.cannotMove && mon->info.flags.summon)
			break;
		++mon;
		if (++i >= 20)
			return TRUE;
	}
	return FALSE;
}

/*
 *
 * If attempting to clone when there are already 20 creatures
 * on your side, summon clone will fail and return a nullptr
 * from which a nullptr exception is triggered, observed for AI only.
 * This tells the AI that clone value is 0 in such cases.
 *
 */
VOID __stdcall _HH_TooManyCreaturesToCastClone(HiHook* h, H3AiSpellCastInfo* This, H3AiSpellData* spl, int a3)
{
	if (spl->spellId == H3Spell::eSpells::CLONE && MaximumCreaturesReached(P_CombatMgr(), This->side))
	{
		F_MessageBox("Ai tried to summon clone but this would result in a crash!");
		return;
	}
	return THISCALL_3(VOID, h->GetDefaultFunc(), This, spl, a3);
}

/*
 *
 * Scuttle boat action was not saved to replayed actions,
 * resulting in ghost ship that would lead to crashes when embarking.
 *
 */
_LHF_(ReplayScuttleBoat)
{
	auto main = reinterpret_cast<H3Main*>(c->edx);
	auto hero = reinterpret_cast<H3Hero*>(c->esi);
	auto boat = reinterpret_cast<H3Boat*>(c->edi);
	THISCALL_4(VOID, 0x49C1D0, main, boat, 1, hero->id);
	return EXEC_DEFAULT;
}

//////////////////////////////////////////////////////////////////////////
// Hooks init
//////////////////////////////////////////////////////////////////////////

void SoD_SP_Plugin::Fixes()
{
	//////////////////////////////////////////////////
	// AI bugs
	//////////////////////////////////////////////////
	Hook(0x56B344, AiTpCursedCheck);	      // disallow casting Town Portal on cursed ground for AI
	Hook(0x43020E, AiWaterwalkFly);	          // disallow AI from casting Fly if they don't have it (v1)
	Hook(0x42DDA6, AiSplitDiv0);		      // if AI has tactics and shooters, but you have 0 creatures -> crash
	Hook(0x42437D, AI_combat_div0);	          // divides by speed which shouldn't be 0
	Hook(0x426FE4, AI_NecromancyFix);         // Army is deleted before Necromancy action, so skip army deletion and execute it in HH below
	Hook(0x42B146, AI_DeathKnightsAmplifier); // [1.19.0] {Ben80} AI ignores Death Knights when considering to build Necromancy Amplifier
	Hook(0x426EE0, Splice, Thiscall, _HH_AI_NecromancyFix);		    // this HiHook runs the skipped over code from @AI_NecromancyFix
	Hook(0x426390, Splice, Thiscall, _HH_AI_QB_GetDamage);          // don't allow negative damage in QB
	Hook(0x42443B, Call, Thiscall, _HH_AI_QB_hugeArmy);			    // prevent loss to small army
	Hook(0x4274D4, Call, Thiscall, _HH_AI_PreventCreatureSpawning); // flag for below hook
	Hook(0x44A950, Splice, Thiscall, _HH_AI_GetArmyValue);		    // prevent endless turns for negative ai value


	//////////////////////////////////////////////////
	// turret armorer bug
	//////////////////////////////////////////////////
	Hook(0x41E39E, TurretBug1);
	Hook(0x41E4DA, TurretBug2);
	Hook(0x46593E, turret_bug3);

	//////////////////////////////////////////////////
	// GUI errors
	//////////////////////////////////////////////////
	Hook(0x5F4C99, FaerieDialogRmb);   // right click on cast-spell icon didn't give correct text
	Hook(0x5F5320, FaerieDialogHover); // same as above, but for mouse hover
	GuiFixesByIgrik();                            // various DEFs and positions
	horizontalScrollbar_init(m_instance);                 // horizontal scrollbar using arrows not correctly drawn
	BytePatch(0x49E4ED, 0x63);         // Repair Arena Cancel button
	BytePatch(0x41DBE8 + 1, 0x5C);     // if AI is teleporting and you had "Don't show enemy moves" on, it would still check if area is visible and show them

	//////////////////////////////////////////////////
	// Misc errors
	//////////////////////////////////////////////////
	Hook(0x476143, Call, Thiscall, _HH_FirstAidTentTargetEnemy); // [1.18.0]
	Hook(0x5D52BF, ViewHeroScreenRapidly);                         // If you click fast enough in garrison exchange dialog, sourcePage is left as 0 and crash ensues
	Hook(0x4AC157, VisitBankBug);                                  // after viewing hero screen during creature reward of creature bank, potential crash
	Hook(0x465656, EarthquakeBug);                                 // do not kill the first creature stack while using earthquake
	Hook(0x4AC5F5, PreserveMonsterNumber);                         // prevents the loss of upgraded stack creatures from the total number of wandering monsters
	Hook(0x446BCD, WaitPhaseBug);                                  // do not use restore hit points ability a second time in wait phase bug function
	Hook(0x447DA5, EnchantersTargetting);                          // Targetting of Enchanters spells was strictly done on first stack of each side
	WriteJmp(0x464DF1, 0x464DFB);                                         // Wait Phase Bug part 1
	BytePatch(0x4FD495 + 1, 0xA);                                  // error check didn't correctly redirect Hero structure calculation
	WordPatch(0x4F8758, 0x63EB);                                   // disable F1 HELP button effects ~ glitched in modern OS
	static LPCSTR rogue_sound = "rogu";
	DwordPatch(0x67448C, DWORD(rogue_sound));                      // Rogue Sound instead of gremlin sound
	Hook(0x47CA04, DefType1);                                      // [1.19.0] {GrayFace} corrects parameter use for def-type1 on the adventure map (although unused)
	Hook(0x47D69F, DefType1);                                      // [1.19.0] {GrayFace}
	Hook(0x41D433, FixDimensionDoorSpellCost);                     // [1.19.0] use the starting terrain for Dimension Door spell cost calculation
	Hook(0x41D9D4, FixTownPortalSpellCost);                        // [1.19.0] use the starting terrain for Town Portal spell cost calculation
	BytePatch(0x600530 + 1, 0);                                    // [1.19.0] {GrayFace} original instruction is an endless loop
	DwordPatch(0x4C5D09 + 2, 0);                                   // [1.19.0] {GrayFace} event message length is not capped at 65,535 chars
	DwordPatch(0x41B43B, 0xC35DEC89);                              // [1.19.0.8][mov esp, ebp, pop ebp, retn] the tail of this bitset exception is missing from all major 3.2 exe
	//todo written as lohook for now, pondering whether I should make this optional
	// alternative is simply pi->WriteJmp(0x41DA12, 0x41DA2B);
	Hook(0x41DA12, SkipOldTownPortalSpellCost);                    // [1.19.0] skip the old Town Portal spell cost procedure
	Hook(0x492F78, DamageOutputForgetfulness);                     // [1.19.0.7] when showing damage output on mouse hover, forgetfulness was not considered for damage reduction
	Hook(0x54A4A2, RMGPlayerTownSelection);                        // [1.19.0.10] show actual town selection
	Hook(0x43A2C0, Splice, Thiscall, _HH_TooManyCreaturesToCastClone); // [1.19.1.0] prevents AI from casting clone if it has too many creatures
	static constexpr LPCSTR DwarvenTreasureName = "BoRDwf1T.pcx";
	ObjectPatch(P_CmpBonusBuildings()[H3Town::eTown::RAMPART].names[H3Town::eBuildings::B_DWARVEN_TREASURY], DwarvenTreasureName); // [1.19.2.0] Dwarven Treasury bonus building name is missing
	static constexpr LPCSTR LookoutTowerName = "BoTCastW.pcx";
	ObjectPatch(P_CmpBonusBuildings()[H3Town::eTown::TOWER].names[H3Town::eBuildings::B_LOOKOUT_TOWER], LookoutTowerName); // [1.19.2.0] Lookout Tower bonus building name is mispelled

	///////////////////////////////////////////
	// Hero hireability
	///////////////////////////////////////////
	Hook(0x4D7BF0, FixHireables); // swap in town, hire in town, etc.
	Hook(0x4A3D14, FixHireables); // prison

	////////////////////////////////////////////////////////
	// Movement updates that were missing or movement bugs
	////////////////////////////////////////////////////////
	Hook(0x49E340, UpdateMaxLandMovement);                           // after landing, max movement was not always updated
	Hook(0x4AA76B, RecalculateMovementAfterVisitObject);             // only for human ~ useless for AI
	Hook(0x5BE69A, RecaculateMovementAfterExitingTown);              // only for human ~ useless for AI
	Hook(0x4A9173, UpdateSeaMvmtLighthouse);                         // when visiting a Lighthouse, all human heroes in boats should get their movement updated
	Hook(0x4E4D40, CastleLighthouseOwnerCheck);                      // castle's lighthouse only applies to its owner
	Hook(0x5BED30, Splice, Thiscall, _HH_AfterBuildingLighthouse); // when building Castle Lighthouse, update max water movement
	Hook(0x4A2470, Splice, Thiscall, _HH_HeroesMeeting);           // due to HDmod, you can directly switch to second hero, whose max movement is not updated

	//////////////////////////////////////////////////
	// Other
	//////////////////////////////////////////////////
	anchorbug_init(m_instance); // corrects anchor bug in combat
	Hook(0x40B0E2, ResetTextBufferForAdventureHint); // [1.19.0]

	Hook(0x41D093, ReplayScuttleBoat); // [1.19.1.0]
}