Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-Conditioned Sampling doesn't use msa_prev #205

Open
simonlevine opened this issue Mar 2, 2024 · 0 comments
Open

Self-Conditioned Sampling doesn't use msa_prev #205

simonlevine opened this issue Mar 2, 2024 · 0 comments

Comments

@simonlevine
Copy link

https://github.com/RosettaCommons/RFdiffusion/blob/main/rfdiffusion/inference/model_runners.py#L673

            msa_prev, pair_prev, px0, state_prev, alpha, logits, plddt = self.model(msa_masked,
                                msa_full,
                                seq_in,
                                xt_in,
                                idx_pdb,
                                t1d=t1d,
                                t2d=t2d,
                                xyz_t=xyz_t,
                                alpha_t=alpha_t,
                                msa_prev = None,
                                pair_prev = None,
                                state_prev = None,
                                t=torch.tensor(t),
                                return_infer=True,
                                motif_mask=self.diffusion_mask.squeeze().to(self.device))   

In the above sampling code, a previous timestep's features are always set to None. Is this intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant