Fixes #12 and Fixes #14 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to end the test immediately when any of the pings succeed
Adding IPv6 equivalent of the current default IPv4 addresses: Google, CloudFlare and OpenDNS based on komapeb/data_connection_checker#13 (comment)
|
I'm including a fix to #14 as well. |
|
@MrCsabaToth Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to end the test immediately when any of the pings succeed
Status
READY
Breaking Changes
NO
Description
This turned out to be a one keyword change, removing an
awaitso far. I have 6 AWS EC2 IP address for connection test in my app, and some of them started to act up. This caused me 10 seconds default delay. By removing the await there's no more wait. I tried to test the counter case: I put my phone into airplane mode and then the data check determines no connection. So it seems I'm not breaking any functionality.The IPv6 address addition is based on komapeb/data_connection_checker#13 (comment).
Type of Change