Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fee query to GenericMarketMaking bot like BatchExecutor has #27

Open
bghughes opened this issue Jun 13, 2023 · 0 comments
Open

Add a fee query to GenericMarketMaking bot like BatchExecutor has #27

bghughes opened this issue Jun 13, 2023 · 0 comments

Comments

@bghughes
Copy link
Contributor

Note that in #26, we add the fee query ONLY TO THE BATCH EXECUTOR so on OP we know what gasPrice to use. This should be extended to the generic class as well and for now, it is not supported and the generic class may cause users to overpay for gas on OP Mainnet until this is in place.

Perhaps an approach that is chain-specific can be good too as this will only pertain to OP AFAIK. cc #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant