Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current implementation cause callback untouched when using with other Promise library #44

Closed
michaeljayt opened this issue Mar 10, 2015 · 1 comment

Comments

@michaeljayt
Copy link
Contributor

Like Promise.all(), after 2a2ec37 :

var url1, url2, callback1, callback2;
callback1 = function(){
    return 1;
}
callback2 = function(){
    return 2;
}
Promise.all([avalon.get(url1).then(callback1),avalon.get(url2).then(callback2)]).then(function(data){
    // This is expected to be `[1,2]`, 
    // but it just return [avalon.get(url1), avalon.get(url2)],
    // i.e. not propagate the Promise correctly.
    console.log(data);
});
@RubyLouvre
Copy link
Owner

已经修了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants