Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow serializing JSON directly to a stream. #34

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tmccombs
Copy link

No description provided.

@rudolph-miller
Copy link
Owner

How about with :octets t ?

@tmccombs
Copy link
Author

Right, I forgot to mention that it only works with character streams, and octets t overrides it.

Actually, I just thought of a way to add support for octet streams without too much effort, I'll add that to this pull request.

@rudolph-miller
Copy link
Owner

I won't merge any PRs without tests. :(
Please add test cases includes :stream stream and :stream stream :octets t.

And, it's better to me to rename keyword :stream to :output because stream can be input or output. :)

@rudolph-miller
Copy link
Owner

And, I saw PR in fast-io.
After this PR is merged, I will remove (fast-io::flush *stream*) .

@tmccombs tmccombs force-pushed the output-stream branch 2 times, most recently from 19be13a to 4530fc9 Compare January 21, 2016 05:35
Also changed keyword argument from :stream to :output.
@tmccombs
Copy link
Author

Hmmm, I need to update compile-encoder and the compiler macro as well.

@tmccombs
Copy link
Author

I played around with it for a while, but eventually realized that the evals execute the code in a null lexical environment, which makes it difficult to capture the output stream. If you have any ideas on how to get compile-encoder to work with an output stream I would be happy to help implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants