Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Dark Mode Switch #82

Merged
merged 2 commits into from Oct 7, 2020
Merged

Added Dark Mode Switch #82

merged 2 commits into from Oct 7, 2020

Conversation

sainiteshb
Copy link
Contributor

Description

I have added the dark mode switch to the app.
I have added two dependencies

  • provider:
    *fontawesome_icons_flutter:

Fixes # (issue)

Type of change

Dark Mode

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also, summarise the process for us to reproduce.

  • [yes ] Test A: checked through my emulator.
  • [ yes] TestB: Test through flutter test code

Checklist:

  • [ *] My code follows the style guidelines of this application
  • [ *] I have checked the code working on my emulator
  • [ *] I have commented my code for better understanding
  • [ *] These changes generate no new warnings
  • [ *] These changes do not effect the existing functionalities,

Screenshot_1602083920
Screenshot_1602083989
Screenshot_1602084211

@sainiteshb sainiteshb closed this Oct 7, 2020
@sainiteshb sainiteshb reopened this Oct 7, 2020
@hayat-tamboli
Copy link
Member

comment out that local variable theme in the profile page and you will be good to go

image

@hayat-tamboli hayat-tamboli self-requested a review October 7, 2020 15:38
@sainiteshb
Copy link
Contributor Author

yes i have updated the code

@hayat-tamboli hayat-tamboli added ✨design issues related to design/UI/UX 😎frontend issues related to frontend hacktoberfest-accepted labels Oct 7, 2020
@hayat-tamboli hayat-tamboli linked an issue Oct 7, 2020 that may be closed by this pull request
Dark Mode #81
Closed
hayat-tamboli
hayat-tamboli approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@hayat-tamboli hayat-tamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job🔥

@hayat-tamboli hayat-tamboli merged commit 9367407 into Runbhumi:master Oct 7, 2020
@sainiteshb
Copy link
Contributor Author

Thank you 😊

@Manas1820
Copy link
Member

Nice Job @sainiteshb

@sainiteshb sainiteshb deleted the dark-mode branch October 7, 2020 15:50
@sainiteshb
Copy link
Contributor Author

@Manas1820 thank you so much

hayat-tamboli added a commit that referenced this pull request Oct 23, 2020
@hayat-tamboli
Merge pull request #82 from Runbhumi/master
dbbe15e 
[pull] master from Runbhumi:master
hayat-tamboli pushed a commit that referenced this pull request Dec 16, 2020
@sbangariGIT
Merge pull request #82 from Runbhumi/master
78270d7 
upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayat-tamboli hayat-tamboli hayat-tamboli approved these changes

Assignees
No one assigned
Labels
✨design issues related to design/UI/UX 😎frontend issues related to frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark Mode
3 participants
@sainiteshb @hayat-tamboli @Manas1820