Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratelimit plugin don't work on go 1.19 #8

Closed
yingziwu opened this issue Aug 13, 2022 · 1 comment
Closed

ratelimit plugin don't work on go 1.19 #8

yingziwu opened this issue Aug 13, 2022 · 1 comment

Comments

@yingziwu
Copy link

OS: Linux 5.18.16-zen1-1-zen
Go version: go1.19 linux/amd64


step to reproduce:

go install github.com/caddyserver/xcaddy/cmd/xcaddy@latest
xcaddy build \
        --with github.com/RussellLuo/caddy-ext/ratelimit

./caddy

error log:

$ ./caddy  
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set. Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.

goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
        go4.org/unsafe/assume-no-moving-gc@v0.0.0-20211027215541-db492cf91b37/untested.go:25 +0x1f4

@RussellLuo
Copy link
Owner

@yingziwu Thanks for the report! I'll fix this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants