Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -frust-very-long flag to CI #68

Closed
CohenArthur opened this issue Feb 6, 2023 · 4 comments · Fixed by #69
Closed

Add -frust-very-long flag to CI #68

CohenArthur opened this issue Feb 6, 2023 · 4 comments · Fixed by #69
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers priority:high High priority issue. Essential to the project's operation

Comments

@CohenArthur
Copy link
Member

Otherwise this causes the CI to consistently fail.

@CohenArthur CohenArthur added enhancement New feature or request good first issue Good for newcomers priority:high High priority issue. Essential to the project's operation labels Feb 6, 2023
@CohenArthur CohenArthur self-assigned this Feb 6, 2023
@Taym95
Copy link
Contributor

Taym95 commented Feb 6, 2023

Hi, can you point me where CI config are, I can pick it up, thanks

@bjorn3
Copy link
Contributor

bjorn3 commented Feb 6, 2023

https://github.com/Rust-GCC/cargo-gccrs/blob/main/.github/workflows/fmt_build_tests.yml

@CohenArthur
Copy link
Member Author

@Taym95 the actual flag isn't -frust-very-long, I thought I'd be the one taking care of this :) you an look at the CI failure on your PR to see what it should look like exactly. It should be

-frust-incomplete-and-experimental-compiler-do-not-use

And I believe you might need to change some code in cargo-gccrs as well to handle GCCRS_EXTRA_FLAGS as an environment variable instead of GCC_EXTRA_FLAGS. I can't remember exactly where that happens but can point it to you soon

@Taym95
Copy link
Contributor

Taym95 commented Feb 6, 2023

@CohenArthur Ah okay you can take care of it, I will keep eye on your implementation to learn from it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority:high High priority issue. Essential to the project's operation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants