Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TestCase API #10

Open
CohenArthur opened this issue Apr 21, 2022 · 0 comments
Open

Improve TestCase API #10

CohenArthur opened this issue Apr 21, 2022 · 0 comments
Labels
priority[low] Low priority issue

Comments

@CohenArthur
Copy link
Member

TestCase::new() and TestCase::Skip do not make a lot of sense when creating the two possible variants of a Test case. Furthermore, does it make sense to keep a builder pattern for non-skipped test cases? If the answer is yes, does it make sense to simply return Skip cases even when calling builder functions, effectively making the call a no-op? Should we panic!() to indicate that the user might be doing something unexpected or silently ignore that as we currently do?

@CohenArthur CohenArthur changed the title Improve TestCase api Improve TestCase API Apr 21, 2022
@CohenArthur CohenArthur added the priority[low] Low priority issue label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority[low] Low priority issue
Projects
None yet
Development

No branches or pull requests

1 participant