Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this merge with my own code, or start anew with a new structure? #2

Closed
stevefan1999-personal opened this issue Sep 21, 2023 · 2 comments · Fixed by #3
Closed

Comments

@stevefan1999-personal
Copy link
Contributor

stevefan1999-personal commented Sep 21, 2023

I happened to have implemented a RustCrypto based suite at stevefan1999-personal/rustls-provider-rustcrypto (github.com). Although it clearly indicates that the code is a PoC, but its crude structure is already capable of running, and I have also implemented some key suites missing from the provider-example in the main rustls repo, this is also mentioned in #1

Well, it is not because that I don't want to send a PR, but I think the intensive use of generics would make it hard to maintain (at least I think code review could be harder), yet at the same time we should NRY (not repeat yourself)...

It's quite a conflict for me over this.

@tarcieri
Copy link
Member

@stevefan1999-personal happy to go with whatever approach you prefer. You could either PR your existing code as-is, or try to break it up into a series of smaller, more incremental PRs that might be easier to review

@tarcieri
Copy link
Member

Also re: crate names, rustls-provider-rustcrypto is an option as well. Curious to see if other providers adopt that convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants