Implement NonIdentity
#1176
Merged
Implement NonIdentity
#1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Jan 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to implement math that is generic over both projective and affine points with a common prime marker trait, see zkcrypto/group#43.
I believe in the meantime we could use
Into<ProjectivePoint<C>> where C: PrimeCurve.In the future I would like to implement the following math (which I believe are correct):
NonIdentitypoints.NonZeroScalar.fn add_identity(&self) -> NonIdentity.Additionally the
PublicKeytype has to be adjusted to returnNonIdentitywhen appopriate, which is a breaking change.On a last point I would like to suggest renaming this to
NonIdentityPoint, which would be more in line withNonZeroScalar.Fixes #1170.