Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Xwing KEM #1506

Closed
rugo opened this issue Feb 13, 2024 · 1 comment
Closed

Adding Xwing KEM #1506

rugo opened this issue Feb 13, 2024 · 1 comment

Comments

@rugo
Copy link

rugo commented Feb 13, 2024

Hi,

I wrote an Xwing implementation in Rust and noticed that you have "reserved" (lol), the xwing crate.
So I assume you're planning to include Xwing into RustCrypto.

I'd be willing to align my code to fit your style and APIs for inclusion into RustCrypto. Before I start however, I wanted to ask if it makes sense to open a PR for this? The RFC is still a draft, but people seem interested to play around with Xwing (which is the only reason I published my code as a crate).

So I wanted to ask:

  • Does it makes sense for me to open a PR for Xwing, if so, where exactly would you want the code?
  • What requirements exist regarding dependencies? So far I use a wrapper around PQClean (a C library with reference and AVX2 implementations, maintained by Thom Wiggers).
  • Whats the status on PQC in RustCrypto? In case PQClean is a dependency you don't want, I'd first have to build a Kyber/MLKEM crate. This would be a fun project for me as I have a background in PQC.

In case you have a developer guideline, feel free to shoot it my way. I didn't find anything on my own.

@tarcieri
Copy link
Member

Awesome! Work on that sort of thing is happening over here, which is where you should open a PR:

RustCrypto/KEMs#1

What requirements exist regarding dependencies?

We generally aim for pure Rust dependencies. As it were, there's a WIP ML-KEM PR open here, which is what we'd prefer you use when it's ready:

RustCrypto/KEMs#2

Re: X25519, we'd prefer curve25519-dalek/x25519-dalek which are also pure Rust

I'm going to close this as it's the wrong repo (though I do see the one I included in the placeholder crate, so my bad) but feel free to continue discussion on the KEMs repo.

@tarcieri tarcieri closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants