cpufeatures: check OS register support #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
commented
Jun 15, 2023
newpavlov
commented
Jun 15, 2023
|
It looks like you're using I was reading about some virtualized environments that didn't implement it yesterday (although I forget specifically which ones, maybe I can dig up a link) |
|
I check it on line 76. Bit 26 of ECX register is responsible for availability of XSAVE, XRSTOR, XSETBV, XGETBV instructions. |
tarcieri
approved these changes
Jun 15, 2023
|
According to this page, there are 3 bits relevant to AVX-512:
Honestly, I have no idea when we should check what. For now to be safe I will check all bits. We may change it in future according to user reports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #793
cc @gabrielesvelto