Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmovnz and cmovz docs are confusing #990

Closed
elahn opened this issue Dec 8, 2023 · 1 comment
Closed

cmovnz and cmovz docs are confusing #990

elahn opened this issue Dec 8, 2023 · 1 comment

Comments

@elahn
Copy link

elahn commented Dec 8, 2023

In the description of both cmovnz and cmovz, it says:

conditionally moves value to self when condition is equal to zero.

The function names and first line of description convey their purpose. In the rest, it might be more clear to separate the function behaviour from instructions used to implement it.

The crate-level docs are excellent. Thank you for publishing the cmov crate! Implementing branch-free algorithms in Rust are no longer blocked on learning inline assembly.

@tarcieri
Copy link
Member

tarcieri commented Dec 9, 2023

Does #991 address your concerns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants