Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmap flag -A is always added, which is not expected based on the documentation #154

Closed
Arnonymous2 opened this issue Aug 15, 2020 · 2 comments · Fixed by #160
Closed

nmap flag -A is always added, which is not expected based on the documentation #154

Arnonymous2 opened this issue Aug 15, 2020 · 2 comments · Fixed by #160
Labels
bug Something isn't working

Comments

@Arnonymous2
Copy link

Describe the bug
The behavior of the nmap scan is not as expected / described on: https://github.com/RustScan/RustScan#-nmap-custom-flags

RustScan automatically runs nmap -vvv -p $PORTS $IP. To make it run -A, execute the command rustscan 127.0.0.1 -- -A.
It looks like the -A flag is added in all cases, also if you don't add -A. I would not expect this, especially if you add different flags and don't want the aggressive (and time consuming) scan.

To Reproduce
Steps to reproduce the behavior:

  1. Start rustscan with :
    rustscan 127.0.0.1 -b 1000 -t 500 --ulimit 5000 -- -sV -sT -Pn
  2. The output is:
    [>] The Nmap command to be run is nmap -sV -sT -Pn -A -p 34648,55016,22 127.0.0.1

Expected behavior
nmap -sV -sT -Pn -p 34648,55016,22 127.0.0.1
without the -A tags added.

Screenshots
rustscan-nmap-A

Desktop (please complete the following information):
Tested on kali linux with the version: rustscan_1.7.1_amd64.deb

Additional context
Already mentioned the issue on Discord, and @kaeros agreed this is not expected behavior.
I guess this is the line where it happens: https://github.com/RustScan/RustScan/blob/master/src/main.rs#L218

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Aug 15, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.92. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@bee-san
Copy link
Member

bee-san commented Aug 19, 2020

Fixed in #160 , thank you! :D

@bee-san bee-san closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants