Add client-side glob expansion on Windows #769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Dec 10, 2022
| // https://github.com/iqlusioninc/abscissa/blob/7c9ab7976145d2920a99ef00eba845efab3247a1/core/src/application.rs#L171-L177 | ||
| // so that we could inject wild::args() instead of std::env::args() | ||
| // which provides glob expansion on Windows | ||
| let args = std::env::args(); |
There was a problem hiding this comment.
Seems like you didn't actually use wild::args?
|
I'm having second thoughts about this being the right approach, and about glib expansion on Windows in the first place. Maybe it is a reasonable default, but then we'd have to provide a command-line flag to disable it, and that cannot be done at this level of abstraction. I'm just going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bumped version to 0.18.0 because this is technically a breaking change - glob paths now have to be escaped on Windows, which wasn't a requirement previously.
But I'm not very familiar with argument parsing on Windows so I may be mistaken about the impact of this. In which case erring on the side of caution is prudent.