fixes commit: https://github.com/RxNT/react-jsonschema-form-condition… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest commit broke all my forms, by switching rulesRunner to use schema & uiSchema from this.state not from the parent function, like it was before. This change introduced bug where if field is removed from schema it can't be placed back, although formData changed back to state where that field should be on schema. You can confirm this on playground.
|
Any chance we can get this merged in? This PR also fixes the issues I am seeing. |
|
We made this change as a fix to an internal issue we had. We have reverted the change and re-published npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…als/commit/df7d62aea94913f4f2f01e1c5048a8dc4f878c34
Latest commit broke all my forms, by switching rulesRunner to use schema & uiSchema from this.state not from the parent function, like it was before. This change introduced bug where if field is removed from schema it can't be placed back, although formData changed back to state where that field should be on schema. You can confirm this on playground.