New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/notification based observation #41
base: master
Are you sure you want to change the base?
Feature/notification based observation #41
Conversation
4bbed87
to
ec4087a
Compare
This is a really large change, and I don't use Core Data enough to review it. Thanks, |
Example/Podfile
Outdated
@@ -3,8 +3,8 @@ source 'https://github.com/CocoaPods/Specs.git' | |||
use_frameworks! | |||
|
|||
target 'RxCoreData_Example' do | |||
pod 'RxSwift', '~> 4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the version bump here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CocoaPods will not be able to resolve RxSwift
dependency, as Podfile
requires version ~> 4.0.0
, while RxCoreData.podspec
specifies ~> 4.2.0
@freak4pc I will give a look on Monday. However @marshallxxx it looks promising. 👍🏿 |
@freak4pc agree, it looks quite large. But mainly it's addition of I've moved few things around, like |
@marshallxxx Can you re-base this to use the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marshallxxx Sorry we totally forget the PR. I reviewed it and I think it's great. I like the idea of Notification based change sets. Are you willing to clean it up and rebase to the current master? If you don't have time I can pick it up myself. But it would great if you just rebase the changes. Thanks
Add notification based
NSManagedObjectContext
change observation.This adds two extra reactive extension to
NSManagedObjectContext
:This would allow us later to create an observable with
NSFetchRequest
which will be notification based instead ofNSFetchedResultsController
. Benefits would be that every time a relationship of a type is changed we can trigger next value.