Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use when inherited #52

Closed
calvingit opened this issue Aug 11, 2017 · 9 comments
Closed

Unable to use when inherited #52

calvingit opened this issue Aug 11, 2017 · 9 comments

Comments

@calvingit
Copy link
Contributor

Install from Cocoapods, the Xcode shows below error message:

'disposeBag' is inaccessible due to 'internal' protection level
@esttorhe
Copy link
Member

Hey @calvingit thanks for reporting.

Would you mind telling me which version of Xcode and also which version of RxViewModel are you trying to use?

Thanks

@calvingit
Copy link
Contributor Author

Xcode: 8.3.3
RxViewModel: 5.0.0

@esttorhe
Copy link
Member

Thanks; I'll take a look later today and hopefully I'll be able to release a new version addressing this issue.

Thanks for reporting.

@esttorhe esttorhe self-assigned this Aug 11, 2017
@freak4pc
Copy link
Member

@calvingit Could you change

RxViewModel.swift:L25 to
public private(set) var disposeBag = DisposeBag()

And confirm if that helps your issue ?

@calvingit
Copy link
Contributor Author

No problem if the disposeBag is public

@freak4pc
Copy link
Member

This project isn't super active - feel free to make a PR with the code I suggested above:

public private(set) var disposeBag = DisposeBag()

@beretis
Copy link

beretis commented Feb 12, 2019

Guys, disposeBag is still not public, every-time i update pods i have to edit it to be public and I think this class is supposed to be superclass. Would you mind changing please? I can make PR buts its so tiny change that its a waste of time :)
Thanks for your time

@calvingit
Copy link
Contributor Author

Check PR #63

@calvingit calvingit reopened this Feb 13, 2019
@esttorhe
Copy link
Member

Fixed with #63 and adb7865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants