Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't download from direct spaces link nor user #17

Closed
jiatern opened this issue Nov 30, 2021 · 7 comments
Closed

Can't download from direct spaces link nor user #17

jiatern opened this issue Nov 30, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@jiatern
Copy link

jiatern commented Nov 30, 2021

Hi, I am using this script on Ubuntu 20.04.2.

I have installed the script from PyPI, but the script returns the following error when I try to download from a live twitter spaces (direct link) or user URL:
image

Is there anything I can do to fix it? Seems like I am the only one facing this issue so far. I am not sure is it due to some dependencies or other factors.

Also, when downloading using -U, some users are not being shown as live even thought the Spaces is still live. I made sure the user selected is the Host of the spaces.

@eggplants
Copy link
Contributor

eggplants commented Nov 30, 2021

str.removesuffix is introduced in Python 3.9. So this project should specify python required version.
If you'd like to use this project right away, please try it with Python 3.9 or higher.
(this project should specify python required version.)

@Ryu1845 Ryu1845 added the bug Something isn't working label Nov 30, 2021
Ryu1845 added a commit that referenced this issue Nov 30, 2021
@Ryu1845
Copy link
Collaborator

Ryu1845 commented Nov 30, 2021

Problem is fixed with latest commit you can install it with

pip install --force-reinstall git+https://github.com/Ryu1845/twspace-dl@main

@Ryu1845
Copy link
Collaborator

Ryu1845 commented Nov 30, 2021

if there's any other bug, feel free to open an other issue.

@Ryu1845 Ryu1845 closed this as completed Nov 30, 2021
Ryu1845 added a commit that referenced this issue Nov 30, 2021
@jiatern
Copy link
Author

jiatern commented Nov 30, 2021

Thanks for the quick fix, for some reasons the error is still there (I see there is another row of code that still uses removesuffix). But I updated python to 3.9 and it is working fine now.

@Ryu1845
Copy link
Collaborator

Ryu1845 commented Nov 30, 2021

Ah my bad sorry for the trouble. I'll reopen until I fix that

@Ryu1845 Ryu1845 reopened this Nov 30, 2021
@Ryu1845
Copy link
Collaborator

Ryu1845 commented Nov 30, 2021

Yeah probably, I couldn't do it right away because I had to leave my computer.

Ryu1845 added a commit that referenced this issue Nov 30, 2021
fix:#17 remove removesuffix method
@Ryu1845 Ryu1845 closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants