Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulma Admin template does not open burger-menu on small screens #176

Closed
Zaid-Ajaj opened this issue Nov 6, 2018 · 3 comments · Fixed by #197
Closed

Fulma Admin template does not open burger-menu on small screens #176

Zaid-Ajaj opened this issue Nov 6, 2018 · 3 comments · Fixed by #197

Comments

@Zaid-Ajaj
Copy link
Contributor

Clicking on the burger-menu button on small screen does not show the navigation menu

Safe template with --layout fulma-admin

fulma-admin-safe

Original Bulma Admin template

fulma-admin-original

@theimowski
Copy link
Member

To make this work we'd need to include some more javascript: https://github.com/dansup/bulma-templates/blob/master/js/bulma.js

@theimowski
Copy link
Member

I've been thinking about this, and came to a conclusion that if we wanted to support that, then we'd ideally implement the burger behaviour via Elmish, which implies new Message just for specific layouts (fulma-admin is not the only one affected).
This in turn would complicate the template itself, adding another conditions.

IMO, we should remove the burger altogether from the layouts, and leave it to the user if one wants to add it.

We loose consistency with bulma-templates, but gain simplicity which in this case is more important.
@Zaid-Ajaj is this fine with you?

@Zaid-Ajaj
Copy link
Contributor Author

IMO, we should remove the burger altogether from the layouts, and leave it to the user if one wants to add it.

Totally agree! this can always be added when necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants