Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with computation statistical significance in CANDID #144

Open
vandalt opened this issue Jul 27, 2022 · 0 comments
Open

Bug with computation statistical significance in CANDID #144

vandalt opened this issue Jul 27, 2022 · 0 comments

Comments

@vandalt
Copy link
Contributor

vandalt commented Jul 27, 2022

There was a bug with the statistical significance computation in CANDID. If I remember correctly my offline discussion with @DrSoulain, the bug is not yet fixed in AMICAL. I just wanted to open an issue to track this. The bug has been fixed in CANDID, so the solution can probably be found somewhere in their code and copied in AMICAL relatively easily. The warning about this in CANDID's README is quoted below.

WARNING: before version 1.0.5 (April 2021), there is a bug in the computation of the statistical significance: the computation are correct below ~4 sigmas, but get progressively overestimated, to double by 14 sigma. In practice, this does not change results, as the significance is only important around or below 4 sigmas. Also, note that the number of sigma cannot go above ~8 with the new (and correct) formula.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant