Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to Maven Central #12

Closed
benmccann opened this issue Jul 30, 2014 · 17 comments
Closed

Publish to Maven Central #12

benmccann opened this issue Jul 30, 2014 · 17 comments

Comments

@benmccann
Copy link
Contributor

It would be easier to integrate into our product if the library were published to Maven Central. This would also solve other problems such as automatically pulling in the required dependencies such as Apache Commons Codec and whatever else is needed.

@benmccann
Copy link
Contributor Author

Depends on #13

@pitbulk
Copy link
Contributor

pitbulk commented Aug 1, 2014

Solved. Thanks for contribute.

@pitbulk pitbulk closed this as completed Aug 1, 2014
@benmccann
Copy link
Contributor Author

This one isn't solved actually. Most Java libraries are published a location called the Maven Central Repository. Then projects can automatically download the code for the library and all of its dependencies (and their dependencies and so on). It would make this code far easier to use if it were available there like nearly every other Java library is.

It looks like there's another library org.opensaml:opensaml:2.6.1, which is already available in Maven Central. It looks like a much more mature library, so I'll probably try to use it. It's maintained by parties like Internet2, Ohio State University, and Georgetown University and is used in popular projects like JBoss, Apache CXF, and Shibboleth. I'm not sure if there's a reason SAML code was re-implemented here, but it might be interesting to make the sample project use the opensaml.org library instead as it probably solves several problems users of this library haven't encountered yet.

@pitbulk
Copy link
Contributor

pitbulk commented Aug 1, 2014

I know the opensaml library (It has years and as you said is used by shibboleth).

We created the php-saml toolkit and we are building new toolkits based on it, translating from php to another languages (java, .net, python). The idea is to have similar workflow and similar settings.
As a big IAM company, we want to manage our own libraries.

@pitbulk
Copy link
Contributor

pitbulk commented Aug 1, 2014

We will publish the the new release of the java-saml toolkit on Maven Central as you suggested

@smchristensen
Copy link

Any update on this?

@dlevis
Copy link

dlevis commented Oct 13, 2015

We would need this too. When can we expect the libraries to be in Maven Central? And why is this marked as closed if it is not done?

@pitbulk
Copy link
Contributor

pitbulk commented Oct 16, 2015

The toolkit is still under development, we plan to publish it at the end of this month.

@mdavidn
Copy link

mdavidn commented Dec 28, 2015

Looked for this on Maven Central this week and did not find it.

@pitbulk
Copy link
Contributor

pitbulk commented May 26, 2016

Not published yet. I'm adding unit test for all the methods and need to write documentation.

For those users that used the 2.0.0 version
Does anyone be able to contribute with the project describing the steps they followed to include the library on their project/IDE?

@pitbulk
Copy link
Contributor

pitbulk commented Aug 5, 2016

Anyone with some spare time to contribute on releasing the new java-saml toolkit?
The code is ready and I implemented a big bunch of unit test to ensure all is working as expected, but I'm not a Java expert so some help with documentation, testing (install and try the toolkit) and guide how prepare the toolkit to be published in maven is very welcome!

@benmccann?

@benmccann
Copy link
Contributor Author

I ended up using pac4j-saml, so I'm afraid I can't help on this one

@miszobi
Copy link
Contributor

miszobi commented Aug 7, 2016

@pitbulk I can help preparing the project for releasing to maven central, and prepare a short guide for doing the actual release. To clarify, would you like to release from the v2.0.0 branch, or from the v1.1.2/master branch (actually what's the difference between the two? Both seem to have the 1.1.2 version)?

For releasing the easiest way to go is to use the Sonatype OSS Repository Hosting. You'll want to follow the linked guide to create a JIRA account, and create a New Project ticket, to claim the 'com.onelogin' groupid, so later on you can use it to publish the project to maven central.

@pitbulk
Copy link
Contributor

pitbulk commented Aug 7, 2016

Hi @miszobi

thanks for the info and for your proposal.

I want to release the v2.0.0 branch (it has a lot of security improvements that aren't in 1.1.2).
I sent the info to my manager to validate the process that you suggested.

P.S I will push a big amount of code with more improvements and unit test for the v2.0.0 this week.

@luuuis
Copy link
Contributor

luuuis commented Aug 8, 2016

I am watching this with interest. I agree that going the Sonatype OSS route is the easiest/best way to go about it, also happy to help where possible.

@RockyMM
Copy link

RockyMM commented Aug 8, 2016

People with far more knowledge than me already have responded, but still I would like to help wherever I can.

@pitbulk
Copy link
Contributor

pitbulk commented Aug 8, 2016

Ok, thanks for the support. I pushed the new code on the v2.0.0 branch.

I think first step is to install manually, configure and test if you experience any issue with the toolkit.

I created this meta-ticket with the pending tasks: #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants