New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DECIMAL type without decimals generates CDS error (inspectTable) #29

Closed

ThePlenkov opened this issue Mar 25, 2021 · 3 comments

Contributor

ThePlenkov commented Mar 25, 2021

Hi!

If we have a column like that

inpectTable gives us file like this:

I'll use same PR #28 to fix it

Contributor Author

ThePlenkov commented Mar 25, 2021

@jung-thomas spec says scale is optional. What do you think to write better in this case Decimal(34) or Decimal(34,0)? Thanks

Contributor Author

ThePlenkov commented Mar 25, 2021

fixed in #28

Contributor

jung-thomas commented Mar 25, 2021

Confirmed fixed

jung-thomas closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment