Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable rule dangerous_statement #13

Open
larshp opened this issue Mar 15, 2022 · 2 comments
Open

enable rule dangerous_statement #13

larshp opened this issue Mar 15, 2022 · 2 comments

Comments

@larshp
Copy link
Collaborator

larshp commented Mar 15, 2022

I've disabled rule dangerous_statement in the config

suggest refactoring and enabling the rule again

suggest that this code, as such, generate the code to memory, where it can be picked up and written as a file to a git repository, from which the dangerous/import can happen

@larshp
Copy link
Collaborator Author

larshp commented Mar 15, 2022

as a consequence, the code must only contain unit tests, suggest moving integration tests to the layer that uses the application

@larshp
Copy link
Collaborator Author

larshp commented Apr 7, 2022

note: the dangerous statements are in testclasses, which is a no-go IMHO

do integration test outside of the normal tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant