Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCRE regexes is 755, latest dev edition is 754 #5

Closed
larshp opened this issue Mar 11, 2022 · 3 comments · Fixed by #35
Closed

PCRE regexes is 755, latest dev edition is 754 #5

larshp opened this issue Mar 11, 2022 · 3 comments · Fixed by #35
Assignees
Labels
good first issue Good for newcomers

Comments

@larshp
Copy link
Collaborator

larshp commented Mar 11, 2022

PCRE regexes is 755, latest dev edition is 754

need to decide the target version of this repository, I'd suggest it follows the latest dev edition

tho it might be difficult, PCRE is a good feature

@albertmink albertmink added the good first issue Good for newcomers label Mar 14, 2022
@albertmink
Copy link
Contributor

Thanks. The dev edition argument is strong and we agree on no PCRE regexes.

@wurzka
Copy link
Contributor

wurzka commented Mar 28, 2022

Most occurrences of PCRE can be easily replaced.

Problems are caused only by this code line:

FIND ALL OCCURRENCES OF PCRE `<p\sclass="shorttext">.*?</p>` IN abap_doc_string RESULTS DATA(result_table).

With PCRE you can enable greedy search by adding ?, REGEX only allows lazy search.
If ? was removed, the occurrence of multiple shorttexes would lead to a strange title.

@larshp
Copy link
Collaborator Author

larshp commented Mar 29, 2022

suggest this workaround, perhaps split it into a method,

1: find all <p\sclass="shorttext">
2: for each of the findings, split at </p>
3: first entry in the split is each a result for result_table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants