feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2224] New FioriButtonStyle support #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API generated for binding property is not correct
Support FioriPrimaryButtonStyle, FioriSecondaryButtonStyle, FioriTertiaryButtonStyle
janhuachu
approved these changes
Oct 18, 2023
|
Should we let Andy review the header docs? |
AndyRogersSAP
suggested changes
Oct 19, 2023
|
|
||
| /// Creates a view that represents the body of a button. | ||
| /// | ||
| /// The system calls this method for each ``Button`` instance in a view |
Apps/Examples/Examples/FioriSwiftUICore/FioriButton/FioriButtonExample.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
…nExample.swift Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
Co-authored-by: AndyRogersSAP <53194232+AndyRogersSAP@users.noreply.github.com>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| fileprivate struct StatefulButton: View { |
There was a problem hiding this comment.
Private over fileprivate Violation: Prefer private over fileprivate declarations. (private_over_fileprivate)
MarcoEidinger
added a commit
that referenced
this pull request
Nov 17, 2023
* 'main' of github.com:SAP/cloud-sdk-ios-fiori: fix: 🐛 [bcp: 0] remove background in ObjectHeader (#614) docs: ✏️ build documentation with DocC and host on swiftpackageindex.com (#613) chore: 🤖 refactor FioriIcon and support accessing cgImage through Image (#612) feat: 🎸 jira 2286 sort & filter for SwiftUI project (#606) fix: 🐛 [bcp: 2370136916] fix width mode for DimensionSelector (#610) feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons chore: 🤖 update CI job for watchOS to use xcode 15 (#609) chore: 🤖 run CI job on macos-13 and xcode 15.0 (#608) feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2224] New FioriButtonStyle support (#603) feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.