Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 馃幐 [JIRA: HCPSDKFIORIUIKIT-2447] navigation bar migration #615

Merged
merged 6 commits into from Dec 1, 2023
Merged

feat: 馃幐 [JIRA: HCPSDKFIORIUIKIT-2447] navigation bar migration #615

merged 6 commits into from Dec 1, 2023

Conversation

xiaoyu0722
Copy link
Contributor

No description provided.

@xiaoyu0722 xiaoyu0722 requested a review from a team as a code owner November 17, 2023 09:54
@xiaoyu0722 xiaoyu0722 requested review from billzhou0223 and removed request for a team November 17, 2023 09:54
@davxu
Copy link
Contributor

davxu commented Nov 17, 2023

@xiaoyu0722 There is some code formatting issue reported by CI Job.
https://github.com/SAP/cloud-sdk-ios-fiori/actions/runs/6902437950/job/18779155371?pr=615
It can be corrected , after changing the format as the diff shows.

shengxu7
shengxu7 reviewed Nov 18, 2023
View reviewed changes
Apps/Examples/Examples/FioriSwiftUICore/NavigationBar/NavigationBarExample.swift
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put Struct NavigationBar{} here instead of the framework? Is there native SwiftUI approach to do the same work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, and there is no good way to handle NavigationBar largeTitle style.

shengxu7
shengxu7 reviewed Nov 18, 2023
View reviewed changes
Apps/Examples/Examples/FioriSwiftUICore/NavigationBar/NavigationBarFioriStyle.swift Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put a NavigationStack {} here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existed navigation bar's style can not be updated, so need a new one to show fiori style.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I present it as sheet, in case the bar is messed with the current one.

@dyongxu
Copy link
Contributor

dyongxu commented Nov 30, 2023

If there is some feature which is doable, but not doable in SwiftUI, please document it here:
https://github.tools.sap/Tango/sdk-ios-swiftui-faq/blob/main/README.md#is-there-limitation-from-swiftui-compared-with-uikit
It can be committed directly without PR.

@dyongxu dyongxu merged commit 26ae03e into main Dec 1, 2023
11 checks passed
@xiaoyu0722 xiaoyu0722 deleted the feat-tabbar-navigationbar branch December 1, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davxu davxu davxu left review comments

@shengxu7 shengxu7 shengxu7 approved these changes

@dyongxu dyongxu dyongxu approved these changes

@billzhou0223 billzhou0223 Awaiting requested review from billzhou0223 billzhou0223 is a code owner automatically assigned from SAP/cloud-sdk-ios-fiori-admin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xiaoyu0722 @davxu @dyongxu @shengxu7 @billzhou0223