Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 [JRIA:HCPSDKFIORIUIKIT-2460] TextInput form cells #669

Merged
merged 3 commits into from Mar 22, 2024
Merged

feat: 🎸 [JRIA:HCPSDKFIORIUIKIT-2460] TextInput form cells #669

merged 3 commits into from Mar 22, 2024

Conversation

janhuachu
Copy link
Contributor

TitleFormView and TextFieldFormView implementation

✅ Closes: HCPSDKFIORIUIKIT-2460

@janhuachu
feat: 🎸 [JRIA:HCPSDKFIORIUIKIT-2460] TextInput form cells
04dea58 
TitleFormView and TextFieldFormView implementation

✅ Closes: HCPSDKFIORIUIKIT-2460
@janhuachu janhuachu requested a review from a team as a code owner March 21, 2024 16:45
@janhuachu janhuachu requested review from billzhou0223 and removed request for a team March 21, 2024 16:45
@janhuachu
Copy link
Contributor Author

Also fixed NoteFormView and KeyValueFormView issues.

@janhuachu
fix: 🐛 [JIRA:HCPSDKFIORIUIKIT-2460] fix force_unwrapping
b7730ae 
fix 2 force_unwrapping swiftlint problems

✅ Closes: HCPSDKFIORIUIKIT-2460
@janhuachu
Copy link
Contributor Author

@billzhou0223 Is it possible to have the subcomponent has the same property in its super-component?
In this case, the controlState is needed in TextInputFieldComponent, PlaceholderTextFieldComponent, and TitleFormViewComponent?

@billzhou0223
Copy link
Contributor

@billzhou0223 Is it possible to have the subcomponent has the same property in its super-component? In this case, the controlState is needed in TextInputFieldComponent, PlaceholderTextFieldComponent, and TitleFormViewComponent?

I see what you mean but it's not possible based on how the style protocol is defined. If the style of sub-components needs to rely on super-components, you current implementation should be the correct way to go.

@janhuachu janhuachu merged commit 20e62c7 into SAP:main Mar 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billzhou0223 billzhou0223 billzhou0223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janhuachu @billzhou0223