Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap.commerce.build 3.9.0 not compatible with 2211.7 (FP1) #48

Closed
andreasschnurbusch opened this issue May 25, 2023 · 5 comments · Fixed by #51
Closed

sap.commerce.build 3.9.0 not compatible with 2211.7 (FP1) #48

andreasschnurbusch opened this issue May 25, 2023 · 5 comments · Fixed by #51

Comments

@andreasschnurbusch
Copy link

The sap.commerce.build fails to invoke ant-tasks when using the latest sap commerce version 2211.7.

The version 2211.6 uses the version number "version=2211.6" in bin/platform/build.number
The version 2211.7 uses "version=2211.FP1". The "FP1" gets converted to a number and fails the build.

error message for input string "FP1"

@mpern
Copy link
Contributor

mpern commented May 25, 2023

Thanks for raising the issue!

You're right, the current parsing doesnt account for FPn yet.
Plus, we also need a way to map .FP1 to .7

@lennartjuette
Copy link

The issue occurred in our builds, too. Confirmed!

I guess the workaround for now is to stick to 2211.6?

@lennartjuette
Copy link

Why would the mapping of FP1 to 7 be required? I'm not even trying to ask why they inserted FP1 here and if there will ever be a FP2.

I'm wondering if it even makes sense to map or change anything.

According to SAP's What's New page 2211.7 is a feature preview (FP) release, which will not be available for download anymore, after the next regular patch 2211.8 comes out.

So wouldn't it be enough to be able to cope with FPx versions, which seem to be ephemeral, but not try to really support them any further? Or are you thinking about any cases where version numbers need to be compared to one another, and the FPx needs to be in the right place?

@mpern
Copy link
Contributor

mpern commented May 28, 2023

So wouldn't it be enough to be able to cope with FPx versions, which seem to be ephemeral, but not try to really support them any further?

You have a point!

Or are you thinking about any cases where version numbers need to be compared to one another, and the FPx needs to be in the right place?

I'm thinking about the manifest.json and the Maven coordinates of preview versions.

But I agee, let's cross that bridge once we get there.

P.S. yes, there will be more feature previews in the future.

@mpern
Copy link
Contributor

mpern commented May 30, 2023

release with 3.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants