Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P3.2][Sourcing][Accessibility][Dialog] Reopening of 10698 #11377

Closed
I543348 opened this issue Feb 8, 2024 · 5 comments · Fixed by #11650
Closed

[P3.2][Sourcing][Accessibility][Dialog] Reopening of 10698 #11377

I543348 opened this issue Feb 8, 2024 · 5 comments · Fixed by #11650
Assignees
Labels
ng15 Angular 15 support

Comments

@I543348
Copy link

I543348 commented Feb 8, 2024

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

This issue is created as #10698 was not being addressed for dialogs such as fd-dialog and value help dialog are reading chrome tab name

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Angular: 15
core/platform: 0.43.26

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Fd-dialog and value help dialog pls refer #10698 for more info

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API?

Did you search for similar issues?

Is there anything else we should know?

@I543348 I543348 changed the title [P3.2] Reopening of 10698 [P3.2][Sourcing][Accessibility][Dialog] Reopening of 10698 Feb 8, 2024
@droshev droshev added this to the Sprint 131 milestone Feb 13, 2024
@mikerodonnell89 mikerodonnell89 removed their assignment Feb 14, 2024
@droshev droshev added the ng15 Angular 15 support label Mar 2, 2024
@droshev droshev removed this from the Sprint 131 milestone Mar 2, 2024
@droshev
Copy link
Contributor

droshev commented Mar 5, 2024

@nikolay-kolarov We would need some guidance from you. :)

@nikolay-kolarov
Copy link

Hi @droshev,

In the current example the value help dialog does not have an aria-labelledby attribute pointing to the title and I think that if it this is added, then the announcement of the page title will be gone. Could you please try this?

Thanks,
Nikolay

@sagar7259
Copy link

sagar7259 commented Apr 24, 2024

Hello,

The issue with reading chrome tab name is only fixed for value-help dialog components and not for fd-dialogs.
Here in fd-dialog, this issue still persists, where the chrome tab title is still being read.

https://deploy-preview-11651--fundamental-ngx.netlify.app/#/core/dialog
Screenshot (1693)

Kindly reopen the ticket.

Regards,
Sagar

@droshev
Copy link
Contributor

droshev commented Apr 25, 2024

@sagar7259 Can you create a stackblitz example only with the dialog?

@mikerodonnell89
Copy link
Member

I am seeing the problem on the provided stackblitz, and the deploy preview from the relevant PR (#11651), but not on the latest deployment of the ng-15 downport:

Screenshot 2024-04-29 at 4 05 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ng15 Angular 15 support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants