-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P3.2][Sourcing][Accessibility][Dialog] Reopening of 10698 #11377
Comments
@nikolay-kolarov We would need some guidance from you. :) |
Hi @droshev, In the current example the value help dialog does not have an aria-labelledby attribute pointing to the title and I think that if it this is added, then the announcement of the page title will be gone. Could you please try this? Thanks, |
Hello, The issue with reading chrome tab name is only fixed for value-help dialog components and not for fd-dialogs. https://deploy-preview-11651--fundamental-ngx.netlify.app/#/core/dialog Kindly reopen the ticket. Regards, |
@sagar7259 Can you create a stackblitz example only with the dialog? |
I am seeing the problem on the provided stackblitz, and the deploy preview from the relevant PR (#11651), but not on the latest deployment of the ng-15 downport: |
Is this a bug, enhancement, or feature request?
Bug
Describe your proposal.
This issue is created as #10698 was not being addressed for dialogs such as fd-dialog and value help dialog are reading chrome tab name
Can you handle that on the application side
No
Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)
Angular: 15
core/platform: 0.43.26
If this is a bug, please provide steps for reproducing it; the exact components you are using;
Fd-dialog and value help dialog pls refer #10698 for more info
Please provide relevant source code (if applicable).
Please provide stackblitz example(s).
In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.
Did you check the documentation and the API?
Did you search for similar issues?
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: