Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal should use fd-overlay classes #465

Closed
mikerodonnell89 opened this issue Jan 29, 2019 · 0 comments · Fixed by #4750
Closed

Modal should use fd-overlay classes #465

mikerodonnell89 opened this issue Jan 29, 2019 · 0 comments · Fixed by #4750
Assignees
@mikerodonnell89
Labels
bug Something isn't working

Comments

@mikerodonnell89
Copy link
Member

Currently the fd-ngx modal is defining its own modal overlay, it should be using .fd-overlay and .fd-overlay--modal from the fiori fundamentals library.

https://sap.github.io/fundamental/demo-pages/modal-overlay-demo-page.html

SAP/fundamental#1205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikerodonnell89 mikerodonnell89

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: (Core) introduce Illustrated Message component SAP/fundamental-ngx
3 participants
@mikerodonnell89 @droshev @MattL75