Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume new fiori fundamentals styles for popper.js #701

Closed
MattL75 opened this issue Apr 9, 2019 · 2 comments · Fixed by #859
Closed

Consume new fiori fundamentals styles for popper.js #701

MattL75 opened this issue Apr 9, 2019 · 2 comments · Fixed by #859
Assignees
@MattL75
Labels
blocked blocked ticket enhancement New feature or request
Milestone
sprint 13 - Hot Pie

Comments

@MattL75
Copy link
Contributor

MattL75 commented Apr 9, 2019 •
edited

We currently have our own css for the popper.js integration. Recently, Greg was nice enough to contribute his styles to the Fundamentals css repo. We should consume these so that all js libraries can be aligned.

Blocked by issues in fundamentals popper.js css:

  • Time picker hardcoded width
  • Datepicker missing side padding
@MattL75 MattL75 added the enhancement New feature or request label Apr 9, 2019
@droshev droshev added this to the Sprint 11 milestone May 3, 2019
@MattL75 MattL75 added the blocked blocked ticket label May 22, 2019
@MattL75
Copy link
Contributor Author

MattL75 commented May 22, 2019

Blocked by fundamental bugs tbd

@droshev
Copy link
Contributor

droshev commented May 30, 2019

If there is an issue in fiori fundamentals then feel free to fix it

@droshev droshev removed the blocked blocked ticket label May 30, 2019
@MattL75 MattL75 added the blocked blocked ticket label Jun 3, 2019
@MattL75 MattL75 mentioned this issue Jun 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattL75 MattL75

Labels
blocked blocked ticket enhancement New feature or request
Projects
None yet
Milestone
sprint 13 - Hot Pie
Development

Successfully merging a pull request may close this issue.

fix: migrate popper styles SAP/fundamental-ngx
3 participants
@mikerodonnell89 @droshev @MattL75