Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose modal container element as a config option #871

Closed
MattL75 opened this issue Jun 6, 2019 · 0 comments
Closed

Expose modal container element as a config option #871

MattL75 opened this issue Jun 6, 2019 · 0 comments
Assignees
@MattL75
Labels
enhancement New feature or request
Projects
board
Milestone
sprint 13 - Hot Pie

Comments

@MattL75
Copy link
Contributor

MattL75 commented Jun 6, 2019

Is this a bug, enhancement, or feature request?

Enhancement

Briefly describe your proposal.

I've had conversations about this issue in the past with a couple stakeholders. Some of them were using inner iframes with relative positioning and the modal would thus be appended to the 'wrong' body and also display weirdly because of the positioning.

With this option, users can control where the modal is appended. Theoretically, this should allow users to have iframes mixed in.
@MattL75 MattL75 added the enhancement New feature or request label Jun 6, 2019
@MattL75 MattL75 added this to the sprint 13 milestone Jun 6, 2019
@MattL75 MattL75 self-assigned this Jun 6, 2019
@MattL75 MattL75 mentioned this issue Jun 6, 2019
Merged
@MattL75 MattL75 closed this as completed Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattL75 MattL75

Labels
enhancement New feature or request
Projects
No open projects
board
  
Awaiting triage
Milestone
sprint 13 - Hot Pie
Development

No branches or pull requests
1 participant
@MattL75