fix(platform): multi combobox bug where inputText is manipulated incorrectly #8793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Visit the preview URL for this PR (updated for commit 10a0e29): https://fundamental-ngx-gh--pr8793-fix-fdp-multi-combob-s62hhvfo.web.app (expires Sat, 08 Oct 2022 19:36:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
mikerodonnell89
changed the title
mikerodonnell89
changed the title
platon-rov
approved these changes
Oct 20, 2022
InnaAtanasova
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8762
When the user enters something into the multi-combobox that returns nothing from the datasource, the combobox input should return to its previous value. There was some logic there previously to remove the last character when this happened, but this often failed due to a lifecycle issue, allowing the user to press the erroneous button twice to see it in the input. Also the previous logic did not account for copy/pastes