Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not disable step input increment/decrement when value is null #8840

Merged
merged 5 commits into from Oct 24, 2022

Conversation

mikerodonnell89
Copy link
Member

fixes #8831

Now matches the functionality of the ui5 web component step input when clearing the input

@mikerodonnell89 mikerodonnell89 added the bug Something isn't working label Oct 13, 2022
@mikerodonnell89 mikerodonnell89 added this to the Sprint 98 - Managua milestone Oct 13, 2022
@mikerodonnell89 mikerodonnell89 requested a review from a team October 13, 2022 18:38
@mikerodonnell89 mikerodonnell89 added this to In progress in Development via automation Oct 13, 2022
@mikerodonnell89 mikerodonnell89 self-assigned this Oct 13, 2022
@netlify
Copy link

netlify bot commented Oct 13, 2022

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit bec0f10
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/63485d5a689b7400091b4252
😎 Deploy Preview https://deploy-preview-8840--fundamental-ngx.netlify.app/docs/fn/input/examples/input-form-group-example.component
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit bec0f10):

https://fundamental-ngx-gh--pr8840-fix-step-input-empty-c1rvcqwz.web.app

(expires Sun, 16 Oct 2022 19:01:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@mikerodonnell89 mikerodonnell89 merged commit 8fb3acd into main Oct 24, 2022
Development automation moved this from In progress to Done Oct 24, 2022
@mikerodonnell89 mikerodonnell89 deleted the fix/step-input-empty-disabled branch October 24, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

Step input increment/decrement gets disabled on value removal
3 participants