Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): fd-emty was used instead fd-only-child #3758

Merged
merged 1 commit into from
Jul 28, 2022
Merged

fix(styles): fd-emty was used instead fd-only-child #3758

merged 1 commit into from
Jul 28, 2022

Conversation

shrvr
Copy link
Contributor

@shrvr shrvr commented Jul 27, 2022 •
edited

Related Issue

Closes #3724
Closes SAP/fundamental-ngx#8431

Description

For object status large size, fd-only-child should be used instead fd-empty.

@shrvr shrvr self-assigned this Jul 27, 2022
@netlify
Copy link

netlify bot commented Jul 27, 2022

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 6c0785c
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/62e19248badda3000841621b
😎 Deploy Preview https://deploy-preview-3758--fundamental-styles.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shrvr shrvr added Bug Something isn't working Defect Hunting labels Jul 27, 2022
@shrvr shrvr merged commit 1c623a6 into main Jul 28, 2022
@shrvr shrvr deleted the fix/inverted-object-status branch July 28, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@platon-rov platon-rov platon-rov approved these changes

Assignees

@shrvr shrvr

Labels
Bug Something isn't working Defect Hunting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Defect Hunting: Object Status bug Object status horizontal alignment issues
3 participants
@shrvr @mikerodonnell89 @platon-rov