fix(styles): form grid margins & paddings issues #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
platon-rov
force-pushed
the
pr/fix/form-layout-margins
branch
from
86bc77e
to
5785914
Compare
platon-rov
changed the title
platon-rov
changed the title
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
BREAKING CHANGE: * Class `fd-form-group__item` removed
BREAKING CHANGE: * Class `fd-form-group__item` removed
BREAKING CHANGE: * Class `fd-col--compact` removed, use `fd-form-item--compact` instead * Class `fd-row__form-item` removed * Class `fd-row--top` removed * Classes applying approach of fd-form-layout-grid changed, see wiki
platon-rov
force-pushed
the
pr/fix/form-layout-margins
branch
from
5785914
to
a0cc1f8
Compare
InnaAtanasova
approved these changes
Aug 12, 2022
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #3574
Refers to SAP/fundamental-ngx#7854
Description
Form container margins fixed.
Screenshots
Form Grid
Before:
Note: Redundant gaps in horizontal mode.
Note: No margins between groups.
After: