feat(styles): add flex to common css (helpers) #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnaAtanasova
changed the title
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
InnaAtanasova
changed the title
g-cheishvili
previously requested changes
Aug 21, 2022
src/styles/flex.scss
Outdated
|
|
||
| // ----------- FLEX ALIGN CONTENT ----------- | ||
| @mixin fd-flex-align-content($type: normal) { | ||
| display: flex; |
There was a problem hiding this comment.
Why not use fd-flex mixin here?
src/styles/flex.scss
Outdated
|
|
||
| // ----------- FLEX ALIGN ITEMS ----------- | ||
| @mixin fd-flex-align-items($type: stretch) { | ||
| display: flex; |
|
This would be much more helpful to end user if we ship raw scss to the npm repo, this way they would be able to use our mixins in case they have scss on their end |
platon-rov
reviewed
Aug 25, 2022
InnaAtanasova
force-pushed
the
feat/common-css-flex
branch
from
83c2d1c
to
34c1b0c
Compare
|
I don't think the examples are working, they are all displaying the same thing (zoomed out) |
|
they should be working now |
platon-rov
reviewed
Sep 1, 2022
| @@ -0,0 +1,955 @@ | |||
| export default { | |||
There was a problem hiding this comment.
empty space below stories
There was a problem hiding this comment.
I don't understand. Where do you see this in the documentation?
droshev
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
common css
Description