Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): full height to shellbar select #3843

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Conversation

shrvr
Copy link
Contributor

@shrvr shrvr commented Sep 1, 2022

Related Issue

Part of SAP/fundamental-ngx#7966

Related NGX PR

SAP/fundamental-ngx#8347

Description

Changed shellbar-select style to fix mouse hover effect.

Screenshots

Before:

Screen Shot 2022-09-01 at 11 54 19 AM

After:

Screen Shot 2022-09-01 at 2 26 44 PM

@shrvr shrvr self-assigned this Sep 1, 2022
@shrvr shrvr added the styling label Sep 1, 2022
@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit d6d76cd
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/6310fc91544735000862532b
😎 Deploy Preview https://deploy-preview-3843--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 187b103
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/631a0cb08aedd300084ece11
😎 Deploy Preview https://deploy-preview-3843--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/styles/shellbar.scss Outdated Show resolved Hide resolved
@shrvr shrvr merged commit 56896d8 into main Sep 8, 2022
@shrvr shrvr deleted the fix/shellbar-select-style branch September 8, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants