Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): icon fonts switching, unloading theme variables bug #3853

Merged
merged 3 commits into from
Sep 7, 2022
Merged

fix(docs): icon fonts switching, unloading theme variables bug #3853

merged 3 commits into from
Sep 7, 2022

Conversation

platon-rov
Copy link
Contributor

@platon-rov platon-rov commented Sep 5, 2022 •
edited

Related Issue

Closes none.

Description

  • variable icon fonts in docs (fiori/horizon)
  • theme variables switching fix (unloading theme variables now works locally without refreshing the page)

@platon-rov platon-rov added the Bug Something isn't working label Sep 5, 2022
@platon-rov platon-rov requested a review from a team September 5, 2022 10:25
@platon-rov platon-rov self-assigned this Sep 5, 2022
@netlify
Copy link

netlify bot commented Sep 5, 2022 •
edited

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 05bd81f
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/631612ff54ef0d000956e6f5
😎 Deploy Preview https://deploy-preview-3853--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@platon-rov platon-rov force-pushed the pr/fix/button-and-storybook-fonts branch from 9bbe55a to 6252f72 Compare September 5, 2022 11:23
@platon-rov platon-rov marked this pull request as draft September 5, 2022 13:18
@platon-rov platon-rov changed the title fix(styles,docs): button fonts & docs theme variables switching fix(styles,docs): button fonts, docs fonts, theme variables switching Sep 5, 2022
@platon-rov platon-rov marked this pull request as ready for review September 5, 2022 14:57
@platon-rov platon-rov force-pushed the pr/fix/button-and-storybook-fonts branch from 9422d14 to 682c419 Compare September 5, 2022 15:16
@platon-rov platon-rov force-pushed the pr/fix/button-and-storybook-fonts branch from 682c419 to 05bd81f Compare September 5, 2022 15:17
@platon-rov platon-rov changed the title fix(styles,docs): button fonts, docs fonts, theme variables switching fix(docs): icon fonts switching, unloading theme variables bug Sep 5, 2022
@InnaAtanasova InnaAtanasova added this to the Sprint 96 - Panama City milestone Sep 6, 2022
@platon-rov platon-rov merged commit c760c77 into main Sep 7, 2022
@platon-rov platon-rov deleted the pr/fix/button-and-storybook-fonts branch September 7, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@platon-rov platon-rov

Labels
Bug Something isn't working
Projects
Development
  
Awaiting triage
Milestone
Sprint 96 - Panama City
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@platon-rov @InnaAtanasova