Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): form message icon in horizon themes #3858

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

platon-rov
Copy link
Contributor

Related Issue

Closes #3804

Description

  • form message icon in horizon themes

Screenshots

Before:

image

After:

Screenshot 2022-09-06 at 11 51 58

@platon-rov platon-rov added the Bug Something isn't working label Sep 6, 2022
@platon-rov platon-rov requested a review from a team September 6, 2022 09:54
@platon-rov platon-rov self-assigned this Sep 6, 2022
@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 93e6896
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/63185dbbef879c0008038e11
😎 Deploy Preview https://deploy-preview-3858--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@InnaAtanasova InnaAtanasova added this to the Sprint 96 - Panama City milestone Sep 6, 2022
src/styles/form-message.scss Outdated Show resolved Hide resolved
src/styles/theming/sap_fiori_3.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@platon-rov platon-rov merged commit c789d5c into main Sep 9, 2022
@platon-rov platon-rov deleted the pr/fix/form-message-icon branch September 9, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Icon missing in Form Message for input validation (Morning Horizon)
2 participants