Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): add focus styles to scrollbar #3915

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

shrvr
Copy link
Contributor

@shrvr shrvr commented Oct 6, 2022

Related Issue

Support for SAP/fundamental-ngx#8780

Description

Added focus mixin with outline none.

Screenshots

Before:

Note: This can only be reproducible on the PR branch of NGX.

image

After:

image

  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)

@shrvr shrvr added this to the Sprint 98 - Managua milestone Oct 6, 2022
@shrvr shrvr requested a review from platon-rov October 6, 2022 18:56
@shrvr shrvr self-assigned this Oct 6, 2022
@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit cc52ac1
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/634f5ed4afbc3e00099dfb94
😎 Deploy Preview https://deploy-preview-3915--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shrvr shrvr force-pushed the feat/scrollbar-focus-outline branch from aa5cad3 to cc52ac1 Compare October 19, 2022 02:20
@shrvr shrvr merged commit 1bf32d6 into main Oct 19, 2022
@shrvr shrvr deleted the feat/scrollbar-focus-outline branch October 19, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants